Bug 33574 - Restriction type is not stored, all restrictions fall back to MANUAL
Summary: Restriction type is not stored, all restrictions fall back to MANUAL
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords: rel_22_11_candidate
Depends on: 31095
Blocks: 16223
  Show dependency treegraph
 
Reported: 2023-04-20 15:25 UTC by Katrin Fischer
Modified: 2023-12-28 20:43 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.05


Attachments
Bug 33574: Correct pointer for restrict_type.code (3.46 KB, patch)
2023-04-20 16:11 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 33574: Correct pointer for restrict_type.code (3.51 KB, patch)
2023-04-20 18:11 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-20 15:25:05 UTC
The new restriction types are not stored anymore and therefore right now, useless :( More so that creates quite an issue for libraries using it as they can no longer differentiate/report etc. properly.

To test:
* Activate PatronRestrictionTypes
* Add a new restriction type from Administration
* Open a patron account and add the new restriction by choosing it from the pull down
* Save
* Review the saved restriction: it says Manual instead of your restriction type.

I the database it's also wrong.
Comment 1 Martin Renvoize 2023-04-20 16:07:30 UTC
Caused by bug 31095
Comment 2 Martin Renvoize 2023-04-20 16:11:00 UTC
Created attachment 149972 [details] [review]
Bug 33574: Correct pointer for restrict_type.code

Somehow this was missed during QA of bug 31095.. likely during a rebase.

Test plan:
1) Check that manual restriction types are now saved.
Comment 3 Tomás Cohen Arazi 2023-04-20 18:11:40 UTC
Created attachment 149983 [details] [review]
Bug 33574: Correct pointer for restrict_type.code

Somehow this was missed during QA of bug 31095.. likely during a rebase.

Test plan:
1) Check that manual restriction types are now saved.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2023-04-20 18:48:25 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Katrin Fischer 2023-04-20 19:27:26 UTC
Lol, I just got to that one! Would be great if it could still make it into 22.11.05 :)
Comment 6 Matt Blenkinsop 2023-04-21 10:35:48 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-05-05 22:32:53 UTC
Not needed in 22.05.x