Bug 33582 - Use template wrapper for breadcrumbs: Tools, part 4
Summary: Use template wrapper for breadcrumbs: Tools, part 4
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Lucas Gass (lukeg)
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-21 12:10 UTC by Owen Leonard
Modified: 2024-07-04 20:37 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:


Attachments
Bug 33582: Use template wrapper for breadcrumbs: Tools, part 4 (11.26 KB, patch)
2023-04-24 11:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33582: Use template wrapper for breadcrumbs: Tools, part 4 (11.33 KB, patch)
2023-04-24 14:09 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33582: Use template wrapper for breadcrumbs: Tools, part 4 (11.38 KB, patch)
2023-04-28 18:02 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-21 12:10:12 UTC
To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs.

- tools/letter.tt
- tools/manage-marc-import.tt
- tools/marc_modification_templates.tt
- tools/modborrowers.tt
- tools/overduerules.tt
Comment 1 Owen Leonard 2023-04-24 11:00:12 UTC
Created attachment 150152 [details] [review]
Bug 33582: Use template wrapper for breadcrumbs: Tools, part 4

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Notices and slips
    - New notice
    - Edit notice
    - Confirm deletion
  - Batch patron modification
  - Overdue notice/status triggers
- Cataloging ->
  - Manage staged records
    - Batch details
  - MARC modification templates
    - Edit actions for a template
Comment 2 PTFS Europe Sandboxes 2023-04-24 14:09:14 UTC
Created attachment 150156 [details] [review]
Bug 33582: Use template wrapper for breadcrumbs: Tools, part 4

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Notices and slips
    - New notice
    - Edit notice
    - Confirm deletion
  - Batch patron modification
  - Overdue notice/status triggers
- Cataloging ->
  - Manage staged records
    - Batch details
  - MARC modification templates
    - Edit actions for a template

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Comment 3 Lucas Gass (lukeg) 2023-04-28 18:02:03 UTC
Created attachment 150407 [details] [review]
Bug 33582: Use template wrapper for breadcrumbs: Tools, part 4

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Notices and slips
    - New notice
    - Edit notice
    - Confirm deletion
  - Batch patron modification
  - Overdue notice/status triggers
- Cataloging ->
  - Manage staged records
    - Batch details
  - MARC modification templates
    - Edit actions for a template

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-05-05 18:43:18 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Martin Renvoize (ashimema) 2023-05-12 15:36:32 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 6 Lucas Gass (lukeg) 2023-06-15 14:46:20 UTC
Missing dependencies for 22.05.x, no backport