Bug 33586 - Library and category are switched in table configuration for patron search results table settings
Summary: Library and category are switched in table configuration for patron search re...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Katrin Fischer
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-21 17:31 UTC by Catrina Berka
Modified: 2024-07-04 20:37 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.14
Circulation function:


Attachments
Bug 33586: Fix sequence of fields for memberresultst in table configuration (1.24 KB, patch)
2023-04-21 19:48 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33586: Fix sequence of fields for memberresultst in table configuration (1.31 KB, patch)
2023-04-21 21:07 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33586: Fix sequence of fields for memberresultst in table configuration (1.38 KB, patch)
2023-04-25 14:18 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Catrina Berka 2023-04-21 17:31:14 UTC
A partner reports the following issue: 
The category and library columns for the table settings for memberresultst are switched. When you check is hidden by default for library, it hides the patron category. When you check is hidden by default for category, it hides the library. 
I am able to replicate this behavior. 
This seems similar to Bug 32461 so I cleared my cache and the issue persists.
Comment 1 Katrin Fischer 2023-04-21 19:48:54 UTC
Created attachment 150069 [details] [review]
Bug 33586: Fix sequence of fields for memberresultst in table configuration

The sequence of options actually matters, not the name.
Library and category were switched, this patch fixes it and
now it should all hide/show as expected:

* Go to administration > table configuration
* Hide library in memberresultst
* Go to patron search and search
* Verify that category was hidden instead
* Apply patch
* Verify now label and columns for library and category
  match with configuration.
Comment 2 PTFS Europe Sandboxes 2023-04-21 21:07:26 UTC
Created attachment 150073 [details] [review]
Bug 33586: Fix sequence of fields for memberresultst in table configuration

The sequence of options actually matters, not the name.
Library and category were switched, this patch fixes it and
now it should all hide/show as expected:

* Go to administration > table configuration
* Hide library in memberresultst
* Go to patron search and search
* Verify that category was hidden instead
* Apply patch
* Verify now label and columns for library and category
  match with configuration.

Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com>
Comment 3 Lisette Scheer 2023-04-21 21:07:50 UTC
Worked as expected. Thanks!
Lisette
Comment 4 Jonathan Druart 2023-04-25 14:18:40 UTC
Created attachment 150209 [details] [review]
Bug 33586: Fix sequence of fields for memberresultst in table configuration

The sequence of options actually matters, not the name.
Library and category were switched, this patch fixes it and
now it should all hide/show as expected:

* Go to administration > table configuration
* Hide library in memberresultst
* Go to patron search and search
* Verify that category was hidden instead
* Apply patch
* Verify now label and columns for library and category
  match with configuration.

Signed-off-by: Lisette Scheer <lisette.scheer@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-05-09 13:51:50 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-05-15 10:36:35 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass (lukeg) 2023-06-15 16:42:38 UTC
Backported to 22.05.x for upcoming 22.05.14.
Comment 8 Danyon Sewell 2023-07-20 04:01:41 UTC
Not backporting to 21.11.x