Bug 33596 - Merge result page is missing page-section
Summary: Merge result page is missing page-section
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-24 06:44 UTC by Katrin Fischer
Modified: 2023-06-13 16:25 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33596: Merge result page is missing page-section (5.10 KB, patch)
2023-04-24 19:18 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33596: Merge result page is missing page-section (5.16 KB, patch)
2023-04-24 22:47 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33596: Merge result page is missing page-section (5.20 KB, patch)
2023-04-24 22:53 UTC, David Nind
Details | Diff | Splinter Review
Bug 33596: Merge result page is missing page-section (5.26 KB, patch)
2023-04-29 20:12 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-24 06:44:24 UTC
When merging 2 records in cataloguing the result shows a little table with the merged records in the last step.

This page is missing page-sectioning.
Comment 1 Owen Leonard 2023-04-24 19:18:58 UTC
Created attachment 150172 [details] [review]
Bug 33596: Merge result page is missing page-section

This patch adds a "page-section" container around the contents of the
page seen when you complete the process of merging catalog records.

The patch also adds the "merge was successful" message into the standard
message dialog.

Perform a catalog search which will return more than one record.

- Select two records in your search results and click "Edit" -> "Merge
  records."
- Complete the process of merging your selected records.
- On the last page you should see a "merge was successful" message
  styled as the standard information box.
- The "Report" section should be shown inside a "page-section" div.
Comment 2 Lucas Gass 2023-04-24 22:47:39 UTC
Created attachment 150175 [details] [review]
Bug 33596: Merge result page is missing page-section

This patch adds a "page-section" container around the contents of the
page seen when you complete the process of merging catalog records.

The patch also adds the "merge was successful" message into the standard
message dialog.

Perform a catalog search which will return more than one record.

- Select two records in your search results and click "Edit" -> "Merge
  records."
- Complete the process of merging your selected records.
- On the last page you should see a "merge was successful" message
  styled as the standard information box.
- The "Report" section should be shown inside a "page-section" div.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 David Nind 2023-04-24 22:53:12 UTC
Created attachment 150177 [details] [review]
Bug 33596: Merge result page is missing page-section

This patch adds a "page-section" container around the contents of the
page seen when you complete the process of merging catalog records.

The patch also adds the "merge was successful" message into the standard
message dialog.

Perform a catalog search which will return more than one record.

- Select two records in your search results and click "Edit" -> "Merge
  records."
- Complete the process of merging your selected records.
- On the last page you should see a "merge was successful" message
  styled as the standard information box.
- The "Report" section should be shown inside a "page-section" div.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Nick Clemens 2023-04-29 20:12:19 UTC
Created attachment 150427 [details] [review]
Bug 33596: Merge result page is missing page-section

This patch adds a "page-section" container around the contents of the
page seen when you complete the process of merging catalog records.

The patch also adds the "merge was successful" message into the standard
message dialog.

Perform a catalog search which will return more than one record.

- Select two records in your search results and click "Edit" -> "Merge
  records."
- Complete the process of merging your selected records.
- On the last page you should see a "merge was successful" message
  styled as the standard information box.
- The "Report" section should be shown inside a "page-section" div.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Tomás Cohen Arazi 2023-05-05 15:14:59 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Martin Renvoize 2023-05-12 15:23:58 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release