Bug 33597 - Get rid of few SameSite warnings
Summary: Get rid of few SameSite warnings
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-24 10:24 UTC by Marcel de Rooy
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.13


Attachments
Bug 33597: Get rid of warning about intranet_bib_list (1.84 KB, patch)
2023-04-24 10:41 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33597: Fix deleting cookie for holdfor(club) (2.38 KB, patch)
2023-04-24 10:41 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33597: (follow-up) Two other occurrences for holdfor (1.32 KB, patch)
2023-04-24 10:52 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33597: (follow-up) Two other occurrences for holdfor (1.32 KB, patch)
2023-04-24 10:54 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33597: Get rid of warning about intranet_bib_list (1.86 KB, patch)
2023-04-28 18:43 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 33597: Fix deleting cookie for holdfor(club) (2.40 KB, patch)
2023-04-28 18:43 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 33597: (follow-up) Two other occurrences for holdfor (1.33 KB, patch)
2023-04-28 18:43 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-04-24 10:24:48 UTC

    
Comment 1 Marcel de Rooy 2023-04-24 10:41:39 UTC
Created attachment 150148 [details] [review]
Bug 33597: Get rid of warning about intranet_bib_list

Resolve:
Cookie “intranet_bib_list” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it.
basket_22.1200022.js:67:65

Test plan:
Do not apply this patch.
Logout from staff.
Check browser console warnings.
Apply this patch.
Login and logout again.
Check warnings again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-04-24 10:41:41 UTC
Created attachment 150149 [details] [review]
Bug 33597: Fix deleting cookie for holdfor(club)

Resolve:
Cookie “holdfor” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it.

Did not see warning for holdforclub. But since it is created with Lax, we should remove it with Lax.

Test plan:
Similar to previous patch. Check console on logout page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2023-04-24 10:48:35 UTC
Trivial patches: self SO
Comment 4 Marcel de Rooy 2023-04-24 10:52:17 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2023-04-24 10:54:30 UTC
Created attachment 150151 [details] [review]
Bug 33597: (follow-up) Two other occurrences for holdfor

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Nick Clemens 2023-04-28 18:43:11 UTC
Created attachment 150413 [details] [review]
Bug 33597: Get rid of warning about intranet_bib_list

Resolve:
Cookie “intranet_bib_list” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it.
basket_22.1200022.js:67:65

Test plan:
Do not apply this patch.
Logout from staff.
Check browser console warnings.
Apply this patch.
Login and logout again.
Check warnings again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Nick Clemens 2023-04-28 18:43:13 UTC
Created attachment 150414 [details] [review]
Bug 33597: Fix deleting cookie for holdfor(club)

Resolve:
Cookie “holdfor” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it.

Did not see warning for holdforclub. But since it is created with Lax, we should remove it with Lax.

Test plan:
Similar to previous patch. Check console on logout page.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Nick Clemens 2023-04-28 18:43:15 UTC
Created attachment 150415 [details] [review]
Bug 33597: (follow-up) Two other occurrences for holdfor

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 9 Nick Clemens 2023-04-28 18:44:07 UTC
I still noted 6 warnings about this, but we don't need to do them all at once :)
Comment 10 Marcel de Rooy 2023-05-01 06:56:00 UTC
(In reply to Nick Clemens from comment #8)
> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Thx Nick
Comment 11 Tomás Cohen Arazi 2023-05-05 12:18:10 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 12 Martin Renvoize 2023-05-11 12:25:52 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 13 Lucas Gass 2023-05-15 22:25:33 UTC
Backported to 22.05.x for upcoming 22.05.13