Bug 33600 - Use template wrapper for breadcrumbs: Tools, part 7
Summary: Use template wrapper for breadcrumbs: Tools, part 7
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-24 11:29 UTC by Owen Leonard
Modified: 2023-06-15 14:53 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33600: Use template wrapper for breadcrumbs: Tools, part 7 (9.44 KB, patch)
2023-04-24 14:29 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33600: Use template wrapper for breadcrumbs: Tools, part 7 (9.50 KB, patch)
2023-04-24 17:13 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33600: Use template wrapper for breadcrumbs: Tools, part 7 (9.55 KB, patch)
2023-05-09 12:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-24 11:29:01 UTC
To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs.

- tools/scheduler.tt
- tools/showdiffmarc.tt
- tools/stage-marc-import.tt
- tools/stockrotation.tt
Comment 1 Owen Leonard 2023-04-24 14:29:38 UTC
Created attachment 150158 [details] [review]
Bug 33600: Use template wrapper for breadcrumbs: Tools, part 7

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Task scheduler
- Cataloging ->
  - Stage MARC records for import (use a batch of MARC records which
    will match existing records)
    - View batch ->
      - View diff of records with a match
  - Stock rotation (must have StockRotation enabled)
    - New rota
    - Edit rota
    - Manage stages
    - Manage items
Comment 2 PTFS Europe Sandboxes 2023-04-24 17:13:45 UTC
Created attachment 150166 [details] [review]
Bug 33600: Use template wrapper for breadcrumbs: Tools, part 7

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Task scheduler
- Cataloging ->
  - Stage MARC records for import (use a batch of MARC records which
    will match existing records)
    - View batch ->
      - View diff of records with a match
  - Stock rotation (must have StockRotation enabled)
    - New rota
    - Edit rota
    - Manage stages
    - Manage items

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Andrew Auld 2023-04-24 17:14:25 UTC
Works beautifully thanks Owen...and I learned how to export and then import marc records!
Comment 4 Katrin Fischer 2023-05-09 12:03:34 UTC
Created attachment 150862 [details] [review]
Bug 33600: Use template wrapper for breadcrumbs: Tools, part 7

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Task scheduler
- Cataloging ->
  - Stage MARC records for import (use a batch of MARC records which
    will match existing records)
    - View batch ->
      - View diff of records with a match
  - Stock rotation (must have StockRotation enabled)
    - New rota
    - Edit rota
    - Manage stages
    - Manage items

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 5 Tomás Cohen Arazi 2023-05-09 13:51:53 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-05-15 10:10:02 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-06-15 14:53:19 UTC
Missing dependencies for 22.05.x, no backport.