Bug 33601 - Use template wrapper for breadcrumbs: Tools, part 8
Summary: Use template wrapper for breadcrumbs: Tools, part 8
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 32507
Blocks:
  Show dependency treegraph
 
Reported: 2023-04-24 11:29 UTC by Owen Leonard
Modified: 2023-06-15 14:53 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8 (9.42 KB, patch)
2023-04-24 17:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8 (9.47 KB, patch)
2023-04-24 19:39 UTC, David Nind
Details | Diff | Splinter Review
Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8 (9.52 KB, patch)
2023-05-09 11:58 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-04-24 11:29:52 UTC
To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs.

- tools/tools-home.tt
- tools/upload-images.tt
- tools/upload.tt
- tools/viewlog.tt
Comment 1 Owen Leonard 2023-04-24 17:40:39 UTC Comment hidden (obsolete)
Comment 2 David Nind 2023-04-24 19:39:58 UTC
Created attachment 150173 [details] [review]
Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Tools home page
    - Log viewer
      - Search result
    - Uploads
      - Upload results
- Cataloging ->
  - Upload local cover image
    - Upload result
    - Test uploading an biblio-level image from the bibliographic detail
      page
    - Test uploading an item-level image from the bibliograhpic detail
      page's holdings table

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-04-24 19:46:11 UTC
Testing notes (using KTD):

1. To test uploading local cover images, enable the LocalCoverImages system preference.

2. For the Upload local cover image: after the first page (when you drag and drop the image), the menu item in the sidebar is not highlighted. It didn't before the patch was applied, so not sure whether it should now.

3. It's nice to have breadcrumbs back for Tools > Additional tools > Uploads!
Comment 4 Katrin Fischer 2023-05-09 11:58:47 UTC
Created attachment 150859 [details] [review]
Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8

This patch updates several templates in the tools directory so that they
use the new WRAPPER for displaying breadcrumbs.

To test, apply the patch and test each page and its variations.
Breadcrumbs should look correct, and each link should be correct.

- Tools ->
  - Tools home page
    - Log viewer
      - Search result
    - Uploads
      - Upload results
- Cataloging ->
  - Upload local cover image
    - Upload result
    - Test uploading an biblio-level image from the bibliographic detail
      page
    - Test uploading an item-level image from the bibliograhpic detail
      page's holdings table

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 5 Tomás Cohen Arazi 2023-05-09 13:51:57 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-05-15 10:10:06 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 7 Lucas Gass 2023-06-15 14:53:47 UTC
Missing dependencies for 22.05.x, no backport.