To continue the process started by Bug 32507, this patch will update several more tools templates so that they use the new template wrapper for breadcrumbs. - tools/tools-home.tt - tools/upload-images.tt - tools/upload.tt - tools/viewlog.tt
Created attachment 150168 [details] [review] Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Tools home page - Log viewer - Search result - Uploads - Upload results - Cataloging -> - Upload local cover image - Upload result - Test uploading an biblio-level image from the bibliographic detail page - Test uploading an item-level image from the bibliograhpic detail page's holdings table
Created attachment 150173 [details] [review] Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Tools home page - Log viewer - Search result - Uploads - Upload results - Cataloging -> - Upload local cover image - Upload result - Test uploading an biblio-level image from the bibliographic detail page - Test uploading an item-level image from the bibliograhpic detail page's holdings table Signed-off-by: David Nind <david@davidnind.com>
Testing notes (using KTD): 1. To test uploading local cover images, enable the LocalCoverImages system preference. 2. For the Upload local cover image: after the first page (when you drag and drop the image), the menu item in the sidebar is not highlighted. It didn't before the patch was applied, so not sure whether it should now. 3. It's nice to have breadcrumbs back for Tools > Additional tools > Uploads!
Created attachment 150859 [details] [review] Bug 33601: Use template wrapper for breadcrumbs: Tools, part 8 This patch updates several templates in the tools directory so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Tools home page - Log viewer - Search result - Uploads - Upload results - Cataloging -> - Upload local cover image - Upload result - Test uploading an biblio-level image from the bibliographic detail page - Test uploading an item-level image from the bibliograhpic detail page's holdings table Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Missing dependencies for 22.05.x, no backport.