Bug 33620 - Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowerRelationship is empty
Summary: Don't show patron-privacyguarantor/patron-privacy_guarantor_fines if borrowe...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-26 20:54 UTC by Lucas Gass
Modified: 2023-10-25 08:00 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty (3.63 KB, patch)
2023-04-26 20:58 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty (3.69 KB, patch)
2023-04-27 13:21 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty (3.63 KB, patch)
2023-07-07 16:08 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty (3.73 KB, patch)
2023-09-15 09:40 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-04-26 20:54:46 UTC
On the patron detail screen there are two list items:

-Show checkouts to guarantor 
-Show charges to guarantor

I end up hiding these with CSS often. It would be better if these simply did not show if borrowerRelationship is empty.
Comment 1 Lucas Gass 2023-04-26 20:58:42 UTC
Created attachment 150257 [details] [review]
Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty

To test:
1. Apply patch
2. Have some values in borrowerRelationship.
3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:'
4. Now empty borrowerRelationship.
5. Visit the patron detail page again and you should no longer see either of those fields.
Comment 2 PTFS Europe Sandboxes 2023-04-27 13:21:18 UTC
Created attachment 150297 [details] [review]
Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty

To test:
1. Apply patch
2. Have some values in borrowerRelationship.
3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:'
4. Now empty borrowerRelationship.
5. Visit the patron detail page again and you should no longer see either of those fields.

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Comment 3 Sally 2023-04-27 13:21:43 UTC
Works as described, thanks for the patch.
Comment 4 Lucas Gass 2023-07-07 16:08:55 UTC
Created attachment 153188 [details] [review]
Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty

To test:
1. Apply patch
2. Have some values in borrowerRelationship.
3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:'
4. Now empty borrowerRelationship.
5. Visit the patron detail page again and you should no longer see either of those fields.
Comment 5 Marcel de Rooy 2023-09-15 09:39:43 UTC
(In reply to Sally from comment #3)
> Works as described, thanks for the patch.

You forgot your signoff line, Sally.
Comment 6 Marcel de Rooy 2023-09-15 09:40:07 UTC
Created attachment 155654 [details] [review]
Bug 33620: Don't show guarantor info on details page if borrowerRelationship is empty

To test:
1. Apply patch
2. Have some values in borrowerRelationship.
3. Go to a patron details page and see both 'Show checkouts to guarantor:' and 'Show charges to guarantor:'
4. Now empty borrowerRelationship.
5. Visit the patron detail page again and you should no longer see either of those fields.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Sally 2023-09-25 08:00:39 UTC
(In reply to Marcel de Rooy from comment #5)
> (In reply to Sally from comment #3)
> > Works as described, thanks for the patch.
> 
> You forgot your signoff line, Sally.

I don't think I did?  

I signed off on a sandbox.  You can see my sign off line on comment #2: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33620#c2

It looks like Lucas updated the patch again after my sign off in comments 2 and 3, and added a new patch on comment 4 a few months later?
Comment 8 Tomás Cohen Arazi 2023-10-18 18:43:58 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-10-25 08:00:59 UTC
Enhancement not pushed to 23.05.x