Bug 33631 - results_summary label and content are slightly misaligned in staff interface
Summary: results_summary label and content are slightly misaligned in staff interface
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact:
URL:
Keywords: rel_22_11_candidate
Depends on:
Blocks:
 
Reported: 2023-04-27 15:15 UTC by Lucas Gass
Modified: 2023-06-13 16:26 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33631: Fix alignment issue in results_summary (924 bytes, patch)
2023-04-27 15:18 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33631: Fix alignment issue in results_summary (973 bytes, patch)
2023-04-27 19:21 UTC, David Nind
Details | Diff | Splinter Review
Bug 33631: [alternate] Fix misaligned labels (774 bytes, patch)
2023-04-27 21:09 UTC, Lucas Gass
Details | Diff | Splinter Review
k (831 bytes, patch)
2023-05-01 13:36 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33631: [alternate] Fix misaligned labels (1.16 KB, patch)
2023-05-01 13:37 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33631: [alternate] Fix misaligned labels (1.20 KB, patch)
2023-05-01 18:24 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-04-27 15:15:54 UTC
If you look at the results_summary on either the results or detail pages you will notice that the label and content are slightly misaligned.
Comment 1 Lucas Gass 2023-04-27 15:18:09 UTC
Created attachment 150307 [details] [review]
Bug 33631: Fix alignment issue in results_summary

To test:
1 On staff results or detail page notice that slight misaligmnet between label and content.
2. Apply patch, yarn_build, clear browser cache
3. Look again, alignment should be fixed
Comment 2 David Nind 2023-04-27 19:21:30 UTC
Created attachment 150314 [details] [review]
Bug 33631: Fix alignment issue in results_summary

To test:
1 On staff results or detail page notice that slight misaligmnet between label and content.
2. Apply patch, yarn_build, clear browser cache
3. Look again, alignment should be fixed

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2023-04-27 19:24:12 UTC
Thanks Lucas for reporting and fixing this!

I also noticed some ISBD view labels are slightly misaligned (see for example biblionumber=262 Programming Perl). I can log a separate bug for this if you like.
Comment 4 Lucas Gass 2023-04-27 21:07:58 UTC
(In reply to David Nind from comment #3)
> Thanks Lucas for reporting and fixing this!
> 
> I also noticed some ISBD view labels are slightly misaligned (see for
> example biblionumber=262 Programming Perl). I can log a separate bug for
> this if you like.

David,

I am going to provide an alternative patch that will fix both. I think we can eliminate the vertical-align rule altogether. It will effect all label (element) and .label ( class ) in Koha so it will require a bit more thourough testing.
Comment 5 Lucas Gass 2023-04-27 21:09:47 UTC
Created attachment 150320 [details] [review]
Bug 33631: [alternate] Fix misaligned labels
Comment 6 Marcel de Rooy 2023-04-28 06:39:58 UTC
(In reply to Lucas Gass from comment #4)
> (In reply to David Nind from comment #3)
> > Thanks Lucas for reporting and fixing this!
> > 
> > I also noticed some ISBD view labels are slightly misaligned (see for
> > example biblionumber=262 Programming Perl). I can log a separate bug for
> > this if you like.
> 
> David,
> 
> I am going to provide an alternative patch that will fix both. I think we
> can eliminate the vertical-align rule altogether. It will effect all label
> (element) and .label ( class ) in Koha so it will require a bit more
> thourough testing.

Back to NSO for such testing :)
Comment 7 Katrin Fischer 2023-05-01 13:30:03 UTC
We've also seen this - happy to have a look!
Comment 8 Katrin Fischer 2023-05-01 13:36:10 UTC
Created attachment 150453 [details] [review]
k
Comment 9 Katrin Fischer 2023-05-01 13:37:20 UTC
Created attachment 150454 [details] [review]
Bug 33631: [alternate] Fix misaligned labels

If you look at the results_summary on either the results
or detail pages you will notice that the label and
content are slightly misaligned.

To test:
1. On staff results, detail page, or ISBD details notice
   that slight misaligmnet between label and content.
2. Apply patch, yarn_build, clear browser cache
3. Look again, alignment should be fixed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2023-05-01 13:37:59 UTC
I've fixed the commit message :)
Comment 11 David Nind 2023-05-01 18:06:59 UTC
Thanks for testing and signing off Katrin! (You beat me to it!)

I was working through various screens, but had not found anything - so far, any misalignments I found were already there before the patch.

This also now corrects the display in the search results.

David
Comment 12 Katrin Fischer 2023-05-01 18:12:30 UTC
Please sign-off, then I can use my token for QA :)
Comment 13 David Nind 2023-05-01 18:24:49 UTC
Created attachment 150465 [details] [review]
Bug 33631: [alternate] Fix misaligned labels

If you look at the results_summary on either the results
or detail pages you will notice that the label and
content are slightly misaligned.

To test:
1. On staff results, detail page, or ISBD details notice
   that slight misaligmnet between label and content.
2. Apply patch, yarn_build, clear browser cache
3. Look again, alignment should be fixed

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: David Nind <david@davidnind.com>
Comment 14 David Nind 2023-05-01 18:27:02 UTC
(In reply to Katrin Fischer from comment #12)
> Please sign-off, then I can use my token for QA :)

Done!

I also tested a sample of other pages to see if I noticed any changes (this was in no way comprehensive).

I only identified some minor misalignments that were present before the patch was applied.
Comment 15 Tomás Cohen Arazi 2023-05-05 15:15:08 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 16 Martin Renvoize 2023-05-12 15:24:05 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release