Bug 33663 - Don't hide Suggestions link in side navigation when suggestion preference is disabled
Summary: Don't hide Suggestions link in side navigation when suggestion preference is ...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact: Victor Grousset/tuxayo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-03 14:27 UTC by Katrin Fischer
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07


Attachments
Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled (1.58 KB, patch)
2023-05-10 08:59 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33663: Pass 'suggestion' to the OPAC templates only (3.03 KB, patch)
2023-05-10 09:00 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled (1.64 KB, patch)
2023-05-21 16:44 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33663: Pass 'suggestion' to the OPAC templates only (3.09 KB, patch)
2023-05-21 16:45 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled (1.69 KB, patch)
2023-05-23 18:22 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review
Bug 33663: Pass 'suggestion' to the OPAC templates only (3.15 KB, patch)
2023-05-23 18:22 UTC, Victor Grousset/tuxayo
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-05-03 14:27:30 UTC
There is a mismatch in how we handle the suggestions link in the top navigation (More menu) an the sidebar navigation in the acquisition module.

The link in the More menu is only dependent on the permissions of the user, the link in the sidebar also checks for the suggestion system preference. 

I believe the latter is not correct, as the suggestion pref explicitly mentions the OPAC:

[Enable|Disable] purchase suggestions in the OPAC.

Some libraries use other forms/tools to allow for users to make purchase suggestions. When suggestions are deactivated, they still want to have the feature available in the staff interface. 

We also now have permissions for suggestions, so we can still hide from staff using those if necessary.
Comment 1 Jonathan Druart 2023-05-10 08:59:57 UTC
Created attachment 150950 [details] [review]
Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled

We don't want to depend on the pref for the staff interface.
Comment 2 Jonathan Druart 2023-05-10 09:00:00 UTC
Created attachment 150951 [details] [review]
Bug 33663: Pass 'suggestion' to the OPAC templates only

We don't need it for the staff interface. The previous patch is removing
the only occurrence using it.
Comment 3 Michaela Sieber 2023-05-21 16:43:49 UTC
Test Plan:

Go to system pref and disable 'suggestion' (disable purchase suggestions in the OPAC.)
Go to Acquisition and recognize that the suggestions link in the sidebar navigation in the acquisition module does not appear any more.


Apply Patch
- Go to system pref and disable 'suggestion'
- Go to Acquisition and recognize that the suggestions link in the sidebar navigation in the acquisition module exists
- Sign Off :-)
Comment 4 PTFS Europe Sandboxes 2023-05-21 16:44:59 UTC
Created attachment 151502 [details] [review]
Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled

We don't want to depend on the pref for the staff interface.

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 5 PTFS Europe Sandboxes 2023-05-21 16:45:02 UTC
Created attachment 151503 [details] [review]
Bug 33663: Pass 'suggestion' to the OPAC templates only

We don't need it for the staff interface. The previous patch is removing
the only occurrence using it.

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Comment 6 Victor Grousset/tuxayo 2023-05-23 18:22:01 UTC
Created attachment 151600 [details] [review]
Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled

We don't want to depend on the pref for the staff interface.

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 7 Victor Grousset/tuxayo 2023-05-23 18:22:04 UTC
Created attachment 151601 [details] [review]
Bug 33663: Pass 'suggestion' to the OPAC templates only

We don't need it for the staff interface. The previous patch is removing
the only occurrence using it.

Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 8 Victor Grousset/tuxayo 2023-05-23 18:22:37 UTC
Works, makes sense, QA script happy, code looks good, passing QA :)
Comment 9 Tomás Cohen Arazi 2023-05-23 19:53:41 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 10 Matt Blenkinsop 2023-06-08 17:15:50 UTC
Nice work everyone!

Pushed to stable for 22.11.x