There is a mismatch in how we handle the suggestions link in the top navigation (More menu) an the sidebar navigation in the acquisition module. The link in the More menu is only dependent on the permissions of the user, the link in the sidebar also checks for the suggestion system preference. I believe the latter is not correct, as the suggestion pref explicitly mentions the OPAC: [Enable|Disable] purchase suggestions in the OPAC. Some libraries use other forms/tools to allow for users to make purchase suggestions. When suggestions are deactivated, they still want to have the feature available in the staff interface. We also now have permissions for suggestions, so we can still hide from staff using those if necessary.
Created attachment 150950 [details] [review] Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled We don't want to depend on the pref for the staff interface.
Created attachment 150951 [details] [review] Bug 33663: Pass 'suggestion' to the OPAC templates only We don't need it for the staff interface. The previous patch is removing the only occurrence using it.
Test Plan: Go to system pref and disable 'suggestion' (disable purchase suggestions in the OPAC.) Go to Acquisition and recognize that the suggestions link in the sidebar navigation in the acquisition module does not appear any more. Apply Patch - Go to system pref and disable 'suggestion' - Go to Acquisition and recognize that the suggestions link in the sidebar navigation in the acquisition module exists - Sign Off :-)
Created attachment 151502 [details] [review] Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled We don't want to depend on the pref for the staff interface. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Created attachment 151503 [details] [review] Bug 33663: Pass 'suggestion' to the OPAC templates only We don't need it for the staff interface. The previous patch is removing the only occurrence using it. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
Created attachment 151600 [details] [review] Bug 33663: Don't hide Suggestions link in side navigation when suggestion preference is disabled We don't want to depend on the pref for the staff interface. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Created attachment 151601 [details] [review] Bug 33663: Pass 'suggestion' to the OPAC templates only We don't need it for the staff interface. The previous patch is removing the only occurrence using it. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x