Bug 33672 - Item group features shows when placing holds if EnableItemGroupHolds is disabled
Summary: Item group features shows when placing holds if EnableItemGroupHolds is disabled
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Testopia
URL:
Keywords:
Depends on: 24857
Blocks:
  Show dependency tree / graph
 
Reported: 2023-05-03 22:03 UTC by Katrin Fischer
Modified: 2024-07-04 20:37 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06
Circulation function:

Attachments
Bug 33672: Don't show item group holds on OPAC if not enabled (1.98 KB, patch)
2023-05-04 11:17 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Bug 33672: Don't show item group holds on OPAC if not enabled (2.04 KB, patch)
2023-05-04 21:15 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-05-03 22:03:06 UTC 
If you don't want to allow item group holds, the option to do so should not show on the place hold forms in OPAC and staff interface when EnableItemGroupHolds is disabled.

Currnetly the option always shows.
Comment 1 Nick Clemens (kidclamp) 2023-05-04 11:17:40 UTC 
Created attachment 150648 [details] [review]
Bug 33672: Don't show item group holds on OPAC if not enabled

This patch adds a check of the syspref 'EnbaleItemGroupHolds' to the
opac request form

To test:
1 - Enable 'EnableItemGroups' system preference
2 - On staff client, view a record details
3 - Go to 'Item groups' tab, add a enw group
4 - On holdings tab, select one or more items and add to group
5 - View record in OPAC
6 - PLace a hold
7 - Note group option is visible
8 - Apply patch
9 - Refresh, no group option
10 - Enable 'EnableItemGroupHolds' system preference
11 - Refresh opac page, note group option is visible
Comment 2 Nick Clemens (kidclamp) 2023-05-04 11:18:02 UTC 
I don't recreate on staff, please provide steps if you can
Comment 3 Katrin Fischer 2023-05-04 11:20:53 UTC 
(In reply to Nick Clemens from comment #2)
> I don't recreate on staff, please provide steps if you can

Maybe you are right, I was probably in the OPAC yesterday when I stumbled on this.
Comment 4 Katrin Fischer 2023-05-04 21:15:44 UTC 
Created attachment 150698 [details] [review]
Bug 33672: Don't show item group holds on OPAC if not enabled

This patch adds a check of the syspref 'EnbaleItemGroupHolds' to the
opac request form

To test:
1 - Enable 'EnableItemGroups' system preference
2 - On staff client, view a record details
3 - Go to 'Item groups' tab, add a enw group
4 - On holdings tab, select one or more items and add to group
5 - View record in OPAC
6 - PLace a hold
7 - Note group option is visible
8 - Apply patch
9 - Refresh, no group option
10 - Enable 'EnableItemGroupHolds' system preference
11 - Refresh opac page, note group option is visible

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-05-04 21:18:27 UTC 
Simple template fix, thx Nick!
Comment 6 Tomás Cohen Arazi (tcohen) 2023-05-09 14:48:19 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-05-15 12:21:25 UTC 
Nice work everyone!

Pushed to stable for 22.11.x
Comment 8 Lucas Gass (lukeg) 2023-06-15 18:56:05 UTC 
Missing dependencies for 22.05.x, no backport.