Currently the log for delete_items.pl only shows the item numbers for items that could not be deleted. It would be useful to also show the item's barcode and title information for easier searching.
Created attachment 151823 [details] [review] Bug 33698: Add fields to the verbose output that show the barcode and title of items that cannot be deleted
Test Plan: 1. Checkout an item to a patron. 2. Mark that item as withdrawn. 3. Run misc/cronjobs/deleted_items.pl 4. Confirm that no barcode or title are shown. 5. Apply patch and restart services 6. Run the cron again. 7. Confirm that the barcode and title of the item withdrawn are shown and correct. 8. Sign off!
Created attachment 151846 [details] [review] Bug 33698: Added fields to the verbose output
Created attachment 151847 [details] [review] Bug 33698: Added fields to the verbose output Test Plan: 1. Checkout an item to a patron. 2. Mark that item as withdrawn. 3. Run perl misc/cronjobs/delete_items.pl --where "items.withdrawn != 0" --where "items.withdrawn_on <= ‘xxxx-xx-xx’” --verbose --commit (in the x’s you’ll put the year-month-date for tomorrow) 4. Confirm that no barcode or title are shown. 5. Apply patch and restart services 6. Run the cron again. 7. Confirm that the barcode and title of the item withdrawn are shown and correct. 8. Sign off!
Created attachment 151848 [details] [review] Bug 33698: Added fields to the verbose output Test Plan: 1. Checkout an item to a patron. 2. Mark that item as withdrawn. 3. Run perl misc/cronjobs/delete_items.pl --where "items.withdrawn != 0" --where "items.withdrawn_on <= ‘xxxx-xx-xx’” --verbose --commit (in the x’s you’ll put the year-month-date for tomorrow) 4. Confirm that no barcode or title are shown. 5. Apply patch and restart services 6. Run the cron again. 7. Confirm that the barcode and title of the item withdrawn are shown and correct. 8. Sign off!
Created attachment 151849 [details] [review] Bug 33698: Add fields to the verbose output that show the barcode and title of items that cannot be deleted
Fixed test plan: Test Plan: 1. Checkout an item to a patron. 2. Mark that item as withdrawn. 3. Run perl misc/cronjobs/delete_items.pl --where "items.withdrawn != 0" --where "items.withdrawn_on <= 'xxxx-xx-xx'" --verbose --commit (in the x’s you’ll put the year-month-date for tomorrow) 4. Confirm that no barcode or title are shown. 5. Apply patch and restart services 6. Run the cron again. 7. Confirm that the barcode and title of the item withdrawn are shown and correct. 8. Sign off!
Created attachment 151883 [details] [review] Bug 33698: Add fields to the verbose output that show the barcode and title of items that cannot be deleted Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 152234 [details] [review] Bug 33698: Add fields to the verbose output that show the barcode and title of items that cannot be deleted Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Enhancement, choosing not to backport.