Bug 33699 - Typo in identity_provider_domains.tt (presedence)
Summary: Typo in identity_provider_domains.tt (presedence)
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords: Academy
Depends on: 31378
Blocks:
  Show dependency treegraph
 
Reported: 2023-05-08 20:24 UTC by Caroline Cyr La Rose
Modified: 2023-09-29 11:34 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33699: Typo in identity_provider_domains.tt (presedence) (4.56 KB, patch)
2023-05-10 13:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33699: Typo in identity_provider_domains.tt (presedence) (5.64 KB, patch)
2023-05-10 14:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33699: Typo in identity_provider_domains.tt (presedence) (5.71 KB, patch)
2023-05-10 15:58 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33699: Typo in identity_provider_domains.tt (presedence) (5.80 KB, patch)
2023-05-12 08:44 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-05-08 20:24:58 UTC
In identity_provider_domains.tt, there is a typo in the sentence

Exact matches have presedence over wildcard ones, so 'library.com' domain will take presedence over '*library.com' when the email is 'somebody@library.com'

"presedence" should be "precedence" in both occurrences.
Comment 1 Caroline Cyr La Rose 2023-05-08 20:37:31 UTC
I just noticed there is more than one sentence with the term "presedence".

The same way, the longest match will take presedence over the shorter one, so '*teacher.university.com' will take presedence over '*.university.com' if the email is 'user@math.teacher.university.com'

Each sentence is repeated twice in the file, for a total of 8 occurrences of "presedence" to correct.

I also noticed that one of the sentences has superfluous words.

Exact matches have presedence over asterix ones, so if the 'library.com' domain will take presedence over '*library.com' when the email is 'somebody@library.com'

"so if the" in the other sentence that is the same is simply "so".
Comment 2 Owen Leonard 2023-05-10 13:42:44 UTC
Created attachment 151008 [details] [review]
Bug 33699: Typo in identity_provider_domains.tt (presedence)

This patch corrects the typo "presedence" with "precedence."

The patch also corrects some grammar:

"so if the 'library.com' domain will take presedence over
'*library.com'"

...changed to...

"so 'library.com' domain will take presedence over '*library.com'"

I also changed the <div>s inside that block of help text to <p> in order
to improve legibility.

To test, apply the patch and go to Administration -> Identity providers
-> Manage domains (on an existing provider) -> Edit, and click the
"More" button under the "Domain" field.

Confirm that the text is correct.
Comment 3 Caroline Cyr La Rose 2023-05-10 14:10:03 UTC
Thanks Owen for the correction!

Does the div vs p affect the space between the lines? I noticed that when adding a new domain, the lines are all smushed together, but when editing an existing domain, the lines are spaced out, making it easier to read.
Comment 4 Owen Leonard 2023-05-10 14:28:03 UTC
Whoops, my patch is incomplete!
Comment 5 Owen Leonard 2023-05-10 14:43:14 UTC
Created attachment 151010 [details] [review]
Bug 33699: Typo in identity_provider_domains.tt (presedence)

This patch corrects the typo "presedence" with "precedence."

The patch also corrects some grammar:

"so if the 'library.com' domain will take presedence over
'*library.com'"

...changed to...

"so 'library.com' domain will take presedence over '*library.com'"

I also changed the <div>s inside that block of help text to <p> in order
to improve legibility.

To test, apply the patch and go to Administration -> Identity providers
-> Manage domains (on an existing provider) -> Edit, and click the
"More" button under the "Domain" field.

Confirm that the text is correct.
Comment 6 Caroline Cyr La Rose 2023-05-10 15:58:29 UTC
Created attachment 151017 [details] [review]
Bug 33699: Typo in identity_provider_domains.tt (presedence)

This patch corrects the typo "presedence" with "precedence."

The patch also corrects some grammar:

"so if the 'library.com' domain will take presedence over
'*library.com'"

...changed to...

"so 'library.com' domain will take presedence over '*library.com'"

I also changed the <div>s inside that block of help text to <p> in order
to improve legibility.

To test, apply the patch and go to Administration -> Identity providers
-> Manage domains (on an existing provider) -> Edit, and click the
"More" button under the "Domain" field.

Confirm that the text is correct.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 7 Marcel de Rooy 2023-05-12 08:44:05 UTC
Created attachment 151122 [details] [review]
Bug 33699: Typo in identity_provider_domains.tt (presedence)

This patch corrects the typo "presedence" with "precedence."

The patch also corrects some grammar:

"so if the 'library.com' domain will take presedence over
'*library.com'"

...changed to...

"so 'library.com' domain will take presedence over '*library.com'"

I also changed the <div>s inside that block of help text to <p> in order
to improve legibility.

To test, apply the patch and go to Administration -> Identity providers
-> Manage domains (on an existing provider) -> Edit, and click the
"More" button under the "Domain" field.

Confirm that the text is correct.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Tomás Cohen Arazi 2023-05-12 14:21:38 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Matt Blenkinsop 2023-05-15 12:57:50 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 10 Owen Leonard 2023-09-29 11:34:51 UTC
Depends on Bug 31378 - Add a generic OAuth2/OIDC client implementation, not in 22.05.x.