In identity_provider_domains.tt, there is a typo in the sentence Exact matches have presedence over wildcard ones, so 'library.com' domain will take presedence over '*library.com' when the email is 'somebody@library.com' "presedence" should be "precedence" in both occurrences.
I just noticed there is more than one sentence with the term "presedence". The same way, the longest match will take presedence over the shorter one, so '*teacher.university.com' will take presedence over '*.university.com' if the email is 'user@math.teacher.university.com' Each sentence is repeated twice in the file, for a total of 8 occurrences of "presedence" to correct. I also noticed that one of the sentences has superfluous words. Exact matches have presedence over asterix ones, so if the 'library.com' domain will take presedence over '*library.com' when the email is 'somebody@library.com' "so if the" in the other sentence that is the same is simply "so".
Created attachment 151008 [details] [review] Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct.
Thanks Owen for the correction! Does the div vs p affect the space between the lines? I noticed that when adding a new domain, the lines are all smushed together, but when editing an existing domain, the lines are spaced out, making it easier to read.
Whoops, my patch is incomplete!
Created attachment 151010 [details] [review] Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct.
Created attachment 151017 [details] [review] Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Created attachment 151122 [details] [review] Bug 33699: Typo in identity_provider_domains.tt (presedence) This patch corrects the typo "presedence" with "precedence." The patch also corrects some grammar: "so if the 'library.com' domain will take presedence over '*library.com'" ...changed to... "so 'library.com' domain will take presedence over '*library.com'" I also changed the <div>s inside that block of help text to <p> in order to improve legibility. To test, apply the patch and go to Administration -> Identity providers -> Manage domains (on an existing provider) -> Edit, and click the "More" button under the "Domain" field. Confirm that the text is correct. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Depends on Bug 31378 - Add a generic OAuth2/OIDC client implementation, not in 22.05.x.