Bug 33717 - Typo in search_for_data_inconsistencies.pl
Summary: Typo in search_for_data_inconsistencies.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial (vote)
Assignee: Caroline Cyr La Rose
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-10 18:50 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:47 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07,22.05.15


Attachments
Bug 33717: Typo in search_for_data_inconsistencies.pl (1.38 KB, patch)
2023-05-10 18:56 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33717: Typo in search_for_data_inconsistencies.pl (1.44 KB, patch)
2023-05-14 12:02 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-05-10 18:50:49 UTC
If a biblio has no title, the script output reads

== Biblio without title 245$a ==
	* Biblio with biblionumber=768 does not have title defined
=> Edit these biblio records to defined a title

"defined" in the last sentence should be "define"
Comment 1 Caroline Cyr La Rose 2023-05-10 18:56:48 UTC
Created attachment 151030 [details] [review]
Bug 33717: Typo in search_for_data_inconsistencies.pl

This patch corrects a typo in the output of
search_for_data_inconsistencies.pl when a bibliographic record has no
title.

The patch also replaces biblio to bibliographic record in the same
sentence for terminology consistency.

To test:
- Have a bibliographic record without a title
- Run misc/maintenance/search_for_data_inconsistencies.pl
- Read output, make sure the sentence is correct
Comment 2 Katrin Fischer 2023-05-14 12:02:12 UTC
Created attachment 151175 [details] [review]
Bug 33717: Typo in search_for_data_inconsistencies.pl

This patch corrects a typo in the output of
search_for_data_inconsistencies.pl when a bibliographic record has no
title.

The patch also replaces biblio to bibliographic record in the same
sentence for terminology consistency.

To test:
- Have a bibliographic record without a title
- Run misc/maintenance/search_for_data_inconsistencies.pl
- Read output, make sure the sentence is correct

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 3 Katrin Fischer 2023-05-14 12:03:03 UTC
Thx, Caroline! Don't forget to assign yourself :)
Comment 4 Tomás Cohen Arazi 2023-05-15 11:52:11 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Pedro Amorim 2023-06-02 11:24:36 UTC
Nice work everyone!

Pushed to 22.11.x for next release