Bug 33727 - Merge Calendar tests
Summary: Merge Calendar tests
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-13 12:25 UTC by Marcel de Rooy
Modified: 2023-12-28 20:46 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08,22.05.16
Circulation function:

Attachments
Bug 33727: Groundwork for Calendar.t (6.06 KB, patch)
2023-05-13 12:27 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33727: Merge both Calendar tests (23.63 KB, patch)
2023-05-13 12:27 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33727: Groundwork for Calendar.t (6.08 KB, patch)
2023-05-14 11:01 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 33727: Merge both Calendar tests (23.65 KB, patch)
2023-05-14 11:01 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 33727: Groundwork for Calendar.t (6.12 KB, patch)
2023-07-14 07:39 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33727: Merge both Calendar tests (23.69 KB, patch)
2023-07-14 07:39 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Bug 33727: (QA follow-up) perl tidy whole file (37.47 KB, patch)
2023-07-14 07:39 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-05-13 12:25:44 UTC 
Move tests from t/Calendar to t/db/Calendar, remove need for Test::DBIx
Comment 1 Marcel de Rooy 2023-05-13 12:27:38 UTC 
Created attachment 151165 [details] [review]
Bug 33727: Groundwork for Calendar.t

Update test while removing need for Test::DBIx::Class.

Test plan:
Run t/Calendar.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-05-13 12:27:41 UTC 
Created attachment 151166 [details] [review]
Bug 33727: Merge both Calendar tests

The old t tests become part of the first subtest.

Test plan:
Run the new t/db_dependent/Calendar.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Katrin Fischer 2023-05-14 11:01:26 UTC 
Created attachment 151168 [details] [review]
Bug 33727: Groundwork for Calendar.t

Update test while removing need for Test::DBIx::Class.

Test plan:
Run t/Calendar.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-05-14 11:01:29 UTC 
Created attachment 151169 [details] [review]
Bug 33727: Merge both Calendar tests

The old t tests become part of the first subtest.

Test plan:
Run the new t/db_dependent/Calendar.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Marcel de Rooy 2023-07-14 07:34:28 UTC 
Top of the SO list now. Trivial patch waiting for 2 months already ;)
Taking liberty to get it further now myself.
Comment 6 Marcel de Rooy 2023-07-14 07:35:13 UTC 
prove t/db_dependent/Calendar.t
t/db_dependent/Calendar.t .. ok
All tests successful.
Files=1, Tests=6,  2 wallclock secs ( 0.05 usr  0.01 sys +  2.23 cusr  0.21 csys =  2.50 CPU)
Result: PASS

 WARN   t/db_dependent/Calendar.t
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 71, now: 210)
   OK     valid

OK OK Will run it thru perltidy
Comment 7 Marcel de Rooy 2023-07-14 07:39:02 UTC 
Created attachment 153432 [details] [review]
Bug 33727: Groundwork for Calendar.t

Update test while removing need for Test::DBIx::Class.

Test plan:
Run t/Calendar.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Marcel de Rooy 2023-07-14 07:39:04 UTC 
Created attachment 153433 [details] [review]
Bug 33727: Merge both Calendar tests

The old t tests become part of the first subtest.

Test plan:
Run the new t/db_dependent/Calendar.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Marcel de Rooy 2023-07-14 07:39:07 UTC 
Created attachment 153434 [details] [review]
Bug 33727: (QA follow-up) perl tidy whole file

Test plan:
Run prove again. Run qa tools.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 10 Marcel de Rooy 2023-07-14 07:39:21 UTC 
 OK     t/db_dependent/Calendar.t
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   SKIP   spelling
   OK     tidiness
   OK     valid
Comment 11 Tomás Cohen Arazi (tcohen) 2023-07-14 15:13:50 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 12 Martin Renvoize (ashimema) 2023-07-18 11:52:02 UTC 
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 13 Matt Blenkinsop 2023-07-18 15:28:53 UTC 
Nice work everyone!

Pushed to oldstable for 22.11.x
Comment 14 Lucas Gass (lukeg) 2023-09-13 20:29:10 UTC 
Backported to 22.05.x for upcoming 22.05.16