Bug 33735 - Misspelling in SMS provier
Summary: Misspelling in SMS provier
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-15 12:13 UTC by Anneli Österman
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07


Attachments
Bug 33735: Misspelling in SMS provier (1.16 KB, patch)
2023-05-15 17:43 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33735: Misspelling in SMS provier (1.21 KB, patch)
2023-05-15 21:43 UTC, David Nind
Details | Diff | Splinter Review
Bug 33735: Misspelling in SMS provier (1.31 KB, patch)
2023-05-17 13:02 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Anneli Österman 2023-05-15 12:13:45 UTC
In Koha/Database/Columns.pm line is misspelling in line 186. There is word "provier" and I think it should be "provider". The complete string is "SMS provier ID (internal)".

I noticed it while translating into Finnish in translate.koha-community.org (https://translate.koha-community.org/fi/22.11/translate/fi-FI-messages.po#unit=27204788). I was translating 22.11 project but the same misspelling is in 23.05 also.
Comment 1 Owen Leonard 2023-05-15 17:43:54 UTC
Created attachment 151201 [details] [review]
Bug 33735: Misspelling in SMS provier

Correct spelling error: "provier" -> "provider"

This change is a one-character edit, I think visual inspection of the
patch is sufficient testing.
Comment 2 David Nind 2023-05-15 21:43:34 UTC
Created attachment 151231 [details] [review]
Bug 33735: Misspelling in SMS provier

Correct spelling error: "provier" -> "provider"

This change is a one-character edit, I think visual inspection of the
patch is sufficient testing.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2023-05-17 13:01:48 UTC
From POD

Static method that returns a hashref with mappings from column names
to descriptions, for several tables. Currently


=> Seems like it was typed at 5 o'clock ?
Comment 4 Marcel de Rooy 2023-05-17 13:02:22 UTC
Created attachment 151336 [details] [review]
Bug 33735: Misspelling in SMS provier

Correct spelling error: "provier" -> "provider"

This change is a one-character edit, I think visual inspection of the
patch is sufficient testing.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Marcel de Rooy 2023-05-17 13:02:37 UTC
Just before string freeze
Comment 6 Tomás Cohen Arazi 2023-05-17 13:29:25 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-06-08 16:35:22 UTC
Nice work everyone!

Pushed to stable for 22.11.x