As part of the bookings workflow, we should add a "bookings" tab to the patron details page.
+1 There is no way to find a booking a patron has scheduled without knowing the title.
Created attachment 161045 [details] [review] Bug 33737: Add bookings tab to patron details
Created attachment 161046 [details] [review] Bug 33737: Fix patron bookings table display issues
Created attachment 161047 [details] [review] Bug 33737: Link from patron bookings to biblio bookings
Rebased after splitting from original bug 29002 submission.
The tab was there but when we tried to cancel the booking. it returns an error.
Also a test plan is needed, we improvised but not knowing the feature, it was difficult
Created attachment 162253 [details] [review] Bug 33737: Add bookings tab to patron details This patch adds a new 'bookings' tab to the bottom of the members details pages. When a patron has any future or current bookings against their record the tab will display the number of bookings in the tab name and on clicking the tab a bookings table will display the current and upcoming bookings.
Created attachment 162254 [details] [review] Bug 33737: Fix patron bookings table display issues
Created attachment 162255 [details] [review] Bug 33737: Link from patron bookings to biblio bookings
Created attachment 162256 [details] [review] Bug 33737: Fix undefined variable issues This patch resolves the undefined bookings_table variable issue reported and also further fixes a subsequent undefined timeline bug that was exposed by the original fix.
As an aside, we're using this in production with those customers at ptfs-e who are early adopters of bookings.
Created attachment 163557 [details] [review] Bug 33737: Fix undefined variable issues This patch resolves the undefined bookings_table variable issue reported and also further fixes a subsequent undefined timeline bug that was exposed by the original fix. Signed-off-by: esther <esther@bywatersolutions.com>
My test plan: 1. Search catalog and find a record. 2. Make item on the record bookable. 3. Place booking 4. Navigate to patron account 5. See the bookings tab on the Patron Details page 6. See the item that was booked. And it worked!
Created attachment 164994 [details] [review] Bug 33737: Add bookings tab to patron details This patch adds a new 'bookings' tab to the bottom of the members details pages. When a patron has any future or current bookings against their record the tab will display the number of bookings in the tab name and on clicking the tab a bookings table will display the current and upcoming bookings. Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 164995 [details] [review] Bug 33737: Fix patron bookings table display issues Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 164996 [details] [review] Bug 33737: Link from patron bookings to biblio bookings Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Created attachment 164997 [details] [review] Bug 33737: Fix undefined variable issues This patch resolves the undefined bookings_table variable issue reported and also further fixes a subsequent undefined timeline bug that was exposed by the original fix. Signed-off-by: Esther Melander <esther@bywatersolutions.com>
Just a rebase.. be nice to get this one in for the next release..
Looking here. Seeing no test plans btw.
Created attachment 166513 [details] [review] Bug 33737: Add bookings tab to patron details This patch adds a new 'bookings' tab to the bottom of the members details pages. When a patron has any future or current bookings against their record the tab will display the number of bookings in the tab name and on clicking the tab a bookings table will display the current and upcoming bookings. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 166514 [details] [review] Bug 33737: Fix patron bookings table display issues Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 166515 [details] [review] Bug 33737: Link from patron bookings to biblio bookings Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 166516 [details] [review] Bug 33737: Fix undefined variable issues This patch resolves the undefined bookings_table variable issue reported and also further fixes a subsequent undefined timeline bug that was exposed by the original fix. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Ignoring this one line: WARN Koha/Patron.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 293, now: 294) The feature feels still bit experimental. Without test plans I had trouble finding my way here. And came across a few warnings and errors. But the patches look good to me.
1) My booking doesn't show :( I'll provide you a screenshot in Mattermost. 2) Translatability koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt + "title": "Booking ID", + "defaultContent": "Any item", Please double fix all the title etc. in the new code there - I didn't copy all out.
Created attachment 166565 [details] [review] Bug 33737: Add bookings tab to patron details This patch adds a new 'bookings' tab to the bottom of the members details pages. When a patron has any future or current bookings against their record the tab will display the number of bookings in the tab name and on clicking the tab a bookings table will display the current and upcoming bookings. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 166566 [details] [review] Bug 33737: Fix patron bookings table display issues Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 166567 [details] [review] Bug 33737: Link from patron bookings to biblio bookings Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 166568 [details] [review] Bug 33737: Fix undefined variable issues This patch resolves the undefined bookings_table variable issue reported and also further fixes a subsequent undefined timeline bug that was exposed by the original fix. Signed-off-by: Esther Melander <esther@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 166570 [details] [review] Bug 33737: (QA follow-up) Translatability Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(In reply to Katrin Fischer from comment #26) > 1) My booking doesn't show :( > > I'll provide you a screenshot in Mattermost. I can't replicate this.. it just works for me. > 2) Translatability > > > koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt > + "title": "Booking ID", > + "defaultContent": "Any item", > > Please double fix all the title etc. in the new code there - I didn't copy > all out. Follow-up included
Created attachment 166573 [details] [review] Bug 33737: (QA follow-up) Translatability Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thx for the translation fixes, booking shows now. Tiny thing: On the bookings table, I can see the "configure" button, but I believe we have no table configuration on this table yet, so the button should not appear. Leaving additional_work_needed for now.
Pushed for 24.05! Well done everyone, thank you!
Created attachment 166577 [details] [review] Bug 33737: (QA follow-up) Add missing column configuration I somehow missed commiting the column configuration bits.
Not backported to 23.11.x