Bug 24295 removed the use of GetTransfer by adding a join to branchtransfers when getting available items. The conditions are right, datearrived and datecancelled are null - but they need to be in the join, otherwise we remove all items with completed transfers from the results
Created attachment 151386 [details] [review] Bug 33761: Unit test
Created attachment 151387 [details] [review] Bug 33761: Alter query to remove items with active transfers from available list Current code removes all items without an active transfer, and any with completed transfers. This patch moves the conditionals for transfers into the join, then adds a new condition to remove items with active transfers. To test: 1 - Apply unit test patch only 2 - prove -v t/db_dependent/HoldsQueue.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/HoldsQueue.t 6 - Success!
Created attachment 151413 [details] [review] Bug 33761: Unit test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 151414 [details] [review] Bug 33761: Alter query to remove items with active transfers from available list Current code removes all items without an active transfer, and any with completed transfers. This patch moves the conditionals for transfers into the join, then adds a new condition to remove items with active transfers. To test: 1 - Apply unit test patch only 2 - prove -v t/db_dependent/HoldsQueue.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/HoldsQueue.t 6 - Success! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for the prompt fix here Nick. Tested and working.. kinda silly I missed it until now. Signing off
As this is critical.. lets go straight for PQA here.. It's a clear and simple fix with solid unit tests. Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Can this be backported to 22.11.x?
Nice work everyone! Pushed to stable for 22.11.x
what is the value of x please ? for 22.11
Found, thanks