Bug 33777 - Get Jenkins green again for Auth_with_shibboleth.t
Summary: Get Jenkins green again for Auth_with_shibboleth.t
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33778
  Show dependency treegraph
 
Reported: 2023-05-19 06:20 UTC by Marcel de Rooy
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07


Attachments
Bug 33777: Fix Auth_with_shibboleth.t (836 bytes, patch)
2023-05-19 06:21 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-05-19 06:20:08 UTC
not ok 5 - checkpw_shib tests

Caused by changes around EmailFieldPrecedence
Comment 1 Marcel de Rooy 2023-05-19 06:21:33 UTC
Created attachment 151453 [details] [review]
Bug 33777: Fix Auth_with_shibboleth.t

We need to 'mock' the new pref EmailFieldPrecedence

Test plan:
Run t/Auth_with_shibboleth.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-05-19 06:22:32 UTC
Pushing right away in the queue for Tomas
Comment 3 Tomás Cohen Arazi 2023-05-19 11:46:51 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 4 Matt Blenkinsop 2023-06-08 16:58:29 UTC
Nice work everyone!

Pushed to stable for 22.11.x