Bug 33785 - A couple more UI changes related to Bug 8179
Summary: A couple more UI changes related to Bug 8179
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on: 8179
Blocks:
  Show dependency tree / graph
 
Reported: 2023-05-19 15:27 UTC by Lucas Gass (lukeg)
Modified: 2024-07-04 20:37 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00
Circulation function:

Attachments
Bug 33785: Some UI fisex to the orderreceive.tt modal (4.33 KB, patch)
2023-05-19 15:31 UTC, Lucas Gass (lukeg) 		Details | Diff | Splinter Review
Bug 33785: Some UI fixes to the orderreceive.tt modal (4.39 KB, patch)
2023-05-19 18:04 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2023-05-19 15:27:08 UTC 
A found a couple more things to fix in the orderreceive.tt modal, related to Bug 8179.

-The select2 dropdown for #bookfund is splitting onto multiple lines in the modal.
-The modal header has a green line extending through it.
-At smaller screen sizes the modal close button ( upper right corner of modal ) drops down below the h4. It should stay on the same line as the h4.
-The modal is not centered on the screen. 
-The toogle inactive/active checkbox can become it's own list element.
-The #current-fund can become a hint
Comment 1 Lucas Gass (lukeg) 2023-05-19 15:31:13 UTC 
Created attachment 151480 [details] [review]
Bug 33785: Some UI fisex to the orderreceive.tt modal

To test:
1. Apply patch
2. Follow the steps in Bug 8179 to generate the modal on orderreceive.tt
3. Check that the following issues have been corrected:
    -The select2 dropdown for #bookfund is splitting onto multiple lines in the modal.
    -The modal header has a green line extending through it.
    -At smaller screen sizes the modal close button ( upper right corner of modal ) drops down below the h4. It should stay on the same line as the h4.
    -The modal is not centered on the screen.
    -The toogle inactive/active checkbox can become it's own list element.
    -The #current-fund can become a hint
Comment 2 Tomás Cohen Arazi (tcohen) 2023-05-19 18:04:40 UTC 
Created attachment 151490 [details] [review]
Bug 33785: Some UI fixes to the orderreceive.tt modal

To test:
1. Apply patch
2. Follow the steps in Bug 8179 to generate the modal on orderreceive.tt
3. Check that the following issues have been corrected:
    -The select2 dropdown for #bookfund is splitting onto multiple lines in the modal.
    -The modal header has a green line extending through it.
    -At smaller screen sizes the modal close button ( upper right corner of modal ) drops down below the h4. It should stay on the same line as the h4.
    -The modal is not centered on the screen.
    -The toogle inactive/active checkbox can become it's own list element.
    -The #current-fund can become a hint

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Tomás Cohen Arazi (tcohen) 2023-05-19 18:06:27 UTC 
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 4 Matt Blenkinsop 2023-06-08 17:03:36 UTC 
Dependency missing - not backporting to 22.11.x