To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared
Created attachment 151563 [details] [review] Bug 33806: Retain specified date when confirming item parts at checkin This patch simply adds hidden inputs to the item parts confirm form to ensure specified checkin date is retained To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared 9 - Apply patch 10 - Repeat 3-7 11 - Confirm date is retained
Created attachment 151570 [details] [review] Bug 33806: Retain specified date when confirming item parts at checkin This patch simply adds hidden inputs to the item parts confirm form to ensure specified checkin date is retained To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared 9 - Apply patch 10 - Repeat 3-7 11 - Confirm date is retained Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org>
Created attachment 151578 [details] [review] Bug 33806: Retain specified date when confirming item parts at checkin This patch simply adds hidden inputs to the item parts confirm form to ensure specified checkin date is retained To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared 9 - Apply patch 10 - Repeat 3-7 11 - Confirm date is retained Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 152275 [details] [review] Bug 33806: Retain specified date when confirming item parts at checkin This patch simply adds hidden inputs to the item parts confirm form to ensure specified checkin date is retained To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared 9 - Apply patch 10 - Repeat 3-7 11 - Confirm date is retained Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Works, makes sense, QA script happy, code looks good, passing QA :)
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to 22.11.x for next release