Bug 33813 - Accessibility: Lists button is not clearly identified
Summary: Accessibility: Lists button is not clearly identified
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 27496
  Show dependency treegraph
 
Reported: 2023-05-23 16:26 UTC by Matt Blenkinsop
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement adds an aria-label to the Lists button in the OPAC masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button.
Version(s) released in:
23.11.00,23.05.01,22.11.07


Attachments
Bug 33813: Masthead lists button requires an aria-label (1.72 KB, patch)
2023-05-23 16:27 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33813: Masthead lists button requires an aria-label (1.72 KB, patch)
2023-05-24 09:19 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33813: Masthead lists button requires an aria-label (1.75 KB, patch)
2023-05-24 10:13 UTC, David Nind
Details | Diff | Splinter Review
Bug 33813: Masthead lists button requires an aria-label (1.80 KB, patch)
2023-05-24 13:44 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2023-05-23 16:26:28 UTC
The Lists button in the OPAC masthead has been identified as not being descriptive enough for screen readers. An aria-label is needed to show that this button provides a dropdown containing the users Lists.
Comment 1 Matt Blenkinsop 2023-05-23 16:27:59 UTC
Created attachment 151595 [details] [review]
Bug 33813: Masthead lists button requires an aria-label

This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button.
Comment 2 Owen Leonard 2023-05-23 18:50:48 UTC
Should we be concerned about using the phrase "Click to..." ? That label wouldn't be acceptable if it were part of a text link.
Comment 3 Lucas Gass 2023-05-23 21:00:50 UTC
(In reply to Owen Leonard from comment #2)
> Should we be concerned about using the phrase "Click to..." ? That label
> wouldn't be acceptable if it were part of a text link.

Yes, "Click to..." doesn't provide anything useful for assistive technologies.

I think something like "Show dropdown with detailed list information" would be better in this case.
Comment 4 David Nind 2023-05-23 23:42:36 UTC
(In reply to Lucas Gass from comment #3)
 
> I think something like "Show dropdown with detailed list information" would
> be better in this case.

+1
Comment 5 Matt Blenkinsop 2023-05-24 09:19:51 UTC
Created attachment 151616 [details] [review]
Bug 33813: Masthead lists button requires an aria-label

This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button.
Comment 6 Matt Blenkinsop 2023-05-24 09:20:18 UTC
Thanks for the input everyone, I've updated the patch accordingly
Comment 7 David Nind 2023-05-24 10:13:51 UTC
Created attachment 151620 [details] [review]
Bug 33813: Masthead lists button requires an aria-label

This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button.

Signed-off-by: David Nind <david@davidnind.com>
Comment 8 Lucas Gass 2023-05-24 13:44:35 UTC
Created attachment 151631 [details] [review]
Bug 33813: Masthead lists button requires an aria-label

This patch adds an aria-label to the Lists button in the masthead. It is currently not descriptive enough and doesn't identify what is displayed when clicking the button.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 9 Tomás Cohen Arazi 2023-06-06 13:01:21 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Matt Blenkinsop 2023-06-12 10:35:28 UTC
Can this be pushed to 23.05? It landed in the queue for 22.11.07 but doesn't appear to be in stable
Comment 11 Matt Blenkinsop 2023-06-12 10:46:14 UTC
Ignore that - was looking at the wrong branch!
Comment 12 Matt Blenkinsop 2023-06-12 10:55:10 UTC
Updating to 'Pushed to stable' and adding released version before oldstable rmaint activity
Comment 13 Matt Blenkinsop 2023-06-12 10:58:22 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x