To recreate: 1. Make sure PatronAutoComplete is set to 'Don't try'. 2. Go to Tools > Patron lists 3. Create a Patron list 4. Try to use the 'Patron search:' It doesn't work. This is confusing to users. It should either work without autocomplete or be hidden entirely from display. Using 'Add multiple patrons' still works.
Created attachment 151676 [details] [review] Bug 33829: Fix add patron to patron list if PatronAutoComplete is off When adding patrons to a patron list we get a JS error about undefined variables. We can easily fix this problem by defining them even if the pref is not set. We are enabling the auto complete even if PatronAutoComplete if off.
Created attachment 151687 [details] [review] Bug 33829: Fix add patron to patron list if PatronAutoComplete is off When adding patrons to a patron list we get a JS error about undefined variables. We can easily fix this problem by defining them even if the pref is not set. We are enabling the auto complete even if PatronAutoComplete if off. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 151692 [details] [review] Bug 33829: Fix add patron to patron list if PatronAutoComplete is off When adding patrons to a patron list we get a JS error about undefined variables. We can easily fix this problem by defining them even if the pref is not set. We are enabling the auto complete even if PatronAutoComplete if off. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Simple change that makes sense. Now works both with PatronAutoComplete on or off. QA script doesn't complain. Passing QA. Thanks Jonathan!
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x