---- Reported by bchurch@ptfs.com 2009-07-02 14:13:59 ---- The item due reminder digests (DUEDGST) do not allow you to display title information using the <<biblio.title>> field. You can only display the number of titles that are which is not very helpful to the patron. This is not the case for the individual item due reminders (DUE). The <<items.content>> field also does not work because it only applies to overdue notices. ---- Additional Comments From bchurch@ptfs.com 2009-08-28 13:59:00 ---- There are additional problems with these reminders. The "from" email address uses the email address in the "KohaAdminEmailAddress" preference. It needs to use the "branchemail" address. As well, if you add the library branch fields (example: <<branches.branchname>>) to the notice, the patron sees the field names instead of the library branch data. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:09 UTC --- This bug was previously known as _bug_ 3383 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3383 This bug depended on bug(s) 3203. Actual time not defined. Setting to 0.0 The original reporter of this bug does not have an account here. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. Previous reporter was bchurch@ptfs.com. CC member jwagner@ptfs.com does not have an account here CC member mary.moules@liblime.com does not have an account here
The issue of <<branch.*>> tokens not working in digests is due to an ambiguity of what branch to use, and the potential multiplicity of branches that comes with checkouts from multiple branches. The only constant branchcode on a per-notice basis I could see would be the patron's branch. Can anyone think of a case where a different branch's contact information should be parsed into a PREDUEDGST or DUEDGST notice?
Created attachment 7424 [details] [review] Adds the ability to use branches.* fields in digest notices and have them be parsed correctly. Also adds a warning to the notices editor for digests. Not a complete fix, but it does address one of the issues mentioned in this bug.
Other issues on this bug to be solved: - cannot display the title/author info on the digest notices - the "from" email address is wrong?
Created attachment 8872 [details] [review] Bug 3383 - Item due reminder digests - cannot display title information Adds the ability to use branches.* fields in digest notices and have them be parsed correctly. Also adds a warning to the notices editor for digests.
(In reply to comment #3) I've done some research and testing and found that the from address is being used correctly in master. Also, title/author info can be displayed on digest notices via the <<items.content>> tag. The data cannot be customized, but it is there. > Other issues on this bug to be solved: > - cannot display the title/author info on the digest notices > - the "from" email address is wrong?
Hi Kyle, only a short note: <<items.content>> can be customized using the parameters of the advance_notices.pl cronjob. It would be nice, if the <item></item> syntax would be made available in the item due and due notices, as it is more flexible.
Created attachment 10332 [details] [review] [SIGNED-OFF] Bug 3383 - Item due reminder digests - cannot display title information Adds the ability to use branches.* fields in digest notices and have them be parsed correctly. Also adds a warning to the notices editor for digests. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I like the idea to show a warning, but I would perhaps move it under the message body label to be more obvious. Patch works nicely, branch data of my user's home library is displayed in the notice.
While testing that, I discovered that my branch specific DUEDGST notice was not being used for my notice. Instead the notice template for (All libraries) was used. Filing separate bug 8258 for this.
New subroutine is added to advance_notices.pl that makes use of GetMemberDetails to get the borrower's branchcode. This is incredibly inefficient, and should be replaced with GetMember. See bug 7058.
Created attachment 10613 [details] [review] Bug 3383 - Followup - Switch from GetMemberDetails to GetMember
Created attachment 10888 [details] [review] Bug 3383 - Followup - Switch from GetMemberDetails to GetMember Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
QA comment: * passes koha-qa.pl * small & localised patch * add a relevant warning in notices passed QA
Pushed to the 3.8.x, will be in 3.8.4