Bug 3385 - Add checkout date and renewal date to display list of checked out items
Summary: Add checkout date and renewal date to display list of checked out items
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.6
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-02 03:55 UTC by Chris Cormack
Modified: 2012-10-25 23:09 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Proposed fix (2.68 KB, patch)
2011-10-13 18:48 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Fix for Bug 3385 - Add checkout date and renewal date to display list of checked out items (2.71 KB, patch)
2011-10-14 13:33 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Revised fix (3.65 KB, patch)
2011-11-18 19:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 3385 - Add checkout date and renewal date to display list of checked out items (3.66 KB, patch)
2011-12-03 00:57 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:09:53 UTC


---- Reported by bchurch@ptfs.com 2009-07-02 15:55:33 ----

It would be helpful to have the original checkout date (issuedate) and the last renewal date (lastreneweddate) added to the display list of checked out items which appears in checkout (circulation.pl). Currently there is no way for staff to determine when an item was renewed.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:09 UTC  ---

This bug was previously known as _bug_ 3385 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3385

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was bchurch@ptfs.com.

Comment 1 Katrin Fischer 2010-09-09 15:31:02 UTC
The checkout date is shown on the details and checkouts tabs in circulation and on the item details (Last borrowed) page.

As far as I can tell the last renewal date is shown nowhere.

My library asked about the renewal date, because a patron was claiming that one item has been renewed after he had placed a hold on it. It turned out everything was ok, but there was no way to get the information from the staff interface.

Last renewal date would be a nice addition to the item details page.
Comment 2 Owen Leonard 2011-10-13 18:48:32 UTC Comment hidden (obsolete)
Comment 3 Nicole C. Engard 2011-10-14 13:33:50 UTC Comment hidden (obsolete)
Comment 4 Ian Walls 2011-10-19 16:52:57 UTC
Simple enough Template only change (with corresponding perl code export of required param).  Adds new strings, however, so may need to wait.  Marking Passed QA
Comment 5 Paul Poulain 2011-11-06 09:46:53 UTC
Sorry guys, failed QA, dates are not formatted.

My screen shows :
Last renewed 2011-10-03, Due back on 12/05/2011

The 2nd date is OK, the renewed one is not formatted.
Comment 6 Owen Leonard 2011-11-18 19:55:03 UTC Comment hidden (obsolete)
Comment 7 Chris Cormack 2011-12-03 00:57:20 UTC
Created attachment 6549 [details] [review]
Bug 3385 - Add checkout date and renewal date to display list of checked out items

This patch doesn't fix the origial request to add the renewal date
to the list of checked out items, but follows the other bug commenter's
suggestion that the information be added to the item details page
(moredetail.pl).

The other part of this request, to add the checkout date, has already
been fixed by another patch.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 8 Paul Poulain 2011-12-06 18:22:52 UTC
QA comment:

the following construct:
+    $item->{$_}                        = format_date( $item->{$_} ) foreach qw/datelastborrowed dateaccessioned datelastseen lastreneweddate/;

is not PBP friendly.
It's recommended to write 
foreach {
    bla
}

perlcritic says it's a level 2 severity:
Postfix control "foreach" used at line 131, column 69.  See page 96 of PBP.  (Severity: 2)

We want to be level 5, so passed QA

Patch pushed, please test