Bug 33876 - item-note-nonpublic and item-note-public are difficult to customize in the checkout table
Summary: item-note-nonpublic and item-note-public are difficult to customize in the ch...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-31 22:30 UTC by Lucas Gass
Modified: 2023-10-12 16:00 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.04,22.11.11


Attachments
Bug 33876: Add class for styling (2.66 KB, patch)
2023-05-31 22:41 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33876: Add class for styling (2.70 KB, patch)
2023-06-01 16:20 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 33876: Add class for styling (2.71 KB, patch)
2023-06-13 20:38 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33876: Add class for styling (2.81 KB, patch)
2023-09-08 09:12 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-05-31 22:30:08 UTC
The item-note-nonpublic item-note-public elements in the checkout table are both prepended with a '-' when they are displayed. However those dashes are outside of any HTML element, making them hard to style.

We should either remove them or put them inside of HTML element.
Comment 1 Lucas Gass 2023-05-31 22:41:18 UTC
Created attachment 151891 [details] [review]
Bug 33876: Add class for styling

To test:
1. Checkout and item that has a public and nonpublic note.
2. In the checkout table ( Title column ) notice the notes display. If you use the browser dev tools to inspect you'll notice a "-" outside of any HTML element.
3. Apply patch.
4. See the '-' is now inside of a html element with class of seperator.
Comment 2 Sam Lau 2023-06-01 16:20:58 UTC
Created attachment 151949 [details] [review]
Bug 33876: Add class for styling

To test:
1. Checkout and item that has a public and nonpublic note.
2. In the checkout table ( Title column ) notice the notes display. If you use the browser dev tools to inspect you'll notice a "-" outside of any HTML element.
3. Apply patch.
4. See the '-' is now inside of a html element with class of seperator.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Katrin Fischer 2023-06-08 13:09:54 UTC
Hi Lucas,

all for this change, but some small notes:

* One of the new classes is "seperator", there is a small typo there, as it should be "separator", but that would make it collide with the class in the XSLT and cause some unintended side-effects. Maybe something not used yet?
Comment 4 Lucas Gass 2023-06-13 20:38:39 UTC
Created attachment 152326 [details] [review]
Bug 33876: Add class for styling

To test:
1. Checkout and item that has a public and nonpublic note.
2. In the checkout table ( Title column ) notice the notes display. If you use the browser dev tools to inspect you'll notice a "-" outside of any HTML element.
3. Apply patch.
4. See the '-' is now inside of a html element with class of seperator.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 5 Lucas Gass 2023-06-13 20:39:58 UTC
> * One of the new classes is "seperator", there is a small typo there, as it
> should be "separator", but that would make it collide with the class in the
> XSLT and cause some unintended side-effects. Maybe something not used yet?

Changed it to 'divider-dash'. Keeping Sam's sign-off line.
Comment 6 Marcel de Rooy 2023-09-08 09:12:43 UTC
Created attachment 155381 [details] [review]
Bug 33876: Add class for styling

To test:
1. Checkout and item that has a public and nonpublic note.
2. In the checkout table ( Title column ) notice the notes display. If you use the browser dev tools to inspect you'll notice a "-" outside of any HTML element.
3. Apply patch.
4. See the '-' is now inside of a html element with class of seperator.

Signed-off-by: Sam Lau <samalau@gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Tomás Cohen Arazi 2023-09-18 15:03:50 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Fridolin Somers 2023-09-18 20:57:32 UTC
Nice small enhancement, I choose to backport

Pushed to 23.05.x for 23.05.04
Comment 9 Matt Blenkinsop 2023-10-12 16:00:45 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x