Bug 33877 - Fix teams.yaml
Summary: Fix teams.yaml
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on: 30808
Blocks: 33899
  Show dependency treegraph
 
Reported: 2023-06-01 08:29 UTC by Marcel de Rooy
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.00,22.11.07
Circulation function:


Attachments
Bug 33877: Fix some entries in teams.yaml (2.06 KB, patch)
2023-06-01 08:32 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33877: Add missing team members (967 bytes, patch)
2023-06-01 14:47 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-06-01 08:29:49 UTC
The about page dev section starts with:
Mason James (16.05)

    Packaging manager (17.05)

Mason James (16.11)

    Packaging manager (17.11)

Mason James (17.05)

    Packaging manager (18.05, 18.11)

Mason James (18.05)

    Packaging manager (19.05)

=> The script only expects to find a name here, not a version too. See also maintainer role and how versions are handled there.
In this case I dont think it is really needed to still add that distinction when we had two packaging managers in the past.
Comment 1 Marcel de Rooy 2023-06-01 08:32:49 UTC
Created attachment 151899 [details] [review]
Bug 33877: Fix some entries in teams.yaml

Trivial edit.

Remove versions from the name of the packaging manager.
As also commented on BZ:
The script only expects to find a name here, not a version too.
See also maintainer role and how versions are handled there.
In this case I dont think it is really needed to still add that
distinction when we had two packaging managers in the past.

Test plan:
Look again at about.pl, Koha team, Koha development team.
Look at Mason James.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2023-06-01 08:33:36 UTC
Trivial: self SO
Comment 3 Tomás Cohen Arazi (tcohen) 2023-06-01 14:47:20 UTC
Created attachment 151936 [details] [review]
Bug 33877: Add missing team members

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi (tcohen) 2023-06-01 14:53:31 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-06-12 08:58:27 UTC
Nice work everyone!

Pushed to stable for 22.11.x