Bug 33882 - member.tt Date of birth column makes it difficult to hide the age hint
Summary: member.tt Date of birth column makes it difficult to hide the age hint
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: David Cook
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-01 20:03 UTC by Lucas Gass
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.01,22.11.07


Attachments
Bug 33882: Add spans in dateofbirth column on member.tt (1.65 KB, patch)
2023-06-01 20:07 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33882: Add spans in dateofbirth column on member.tt (1.69 KB, patch)
2023-06-01 20:44 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 33882: Add spans in dateofbirth column on member.tt (1.74 KB, patch)
2023-06-06 06:30 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-06-01 20:03:11 UTC
When doing a patron search ( member.tt) there is a column for Date of Birth. That column also includes a hint about the age of the patron. Example: (67 years)

Some libraries don't want to show information about the patron's age. Currently that info. is difficult to hide with CSS. 

If we wrapped it in an <span> it would be much easier.
Comment 1 Lucas Gass 2023-06-01 20:07:05 UTC
Created attachment 151953 [details] [review]
Bug 33882: Add spans in dateofbirth column on member.tt

To test:
1 Apply patch
2 Do a patron search that will return multiple patrons.
3 Look at the date of birth column and notice the text is now wrapped in a class called 'dateofbirth'
4. Notice that the age hint is wrapped in a class called 'agehint'.
5. Add '.agehint { display: none }' to intranetusercss.
6. Now notice the date of birth still displays but no age information.
Comment 2 Sam Lau 2023-06-01 20:44:03 UTC
Created attachment 151954 [details] [review]
Bug 33882: Add spans in dateofbirth column on member.tt

To test:
1 Apply patch
2 Do a patron search that will return multiple patrons.
3 Look at the date of birth column and notice the text is now wrapped in a class called 'dateofbirth'
4. Notice that the age hint is wrapped in a class called 'agehint'.
5. Add '.agehint { display: none }' to intranetusercss.
6. Now notice the date of birth still displays but no age information.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 David Cook 2023-06-06 06:30:28 UTC
Created attachment 152034 [details] [review]
Bug 33882: Add spans in dateofbirth column on member.tt

To test:
1 Apply patch
2 Do a patron search that will return multiple patrons.
3 Look at the date of birth column and notice the text is now wrapped in a class called 'dateofbirth'
4. Notice that the age hint is wrapped in a class called 'agehint'.
5. Add '.agehint { display: none }' to intranetusercss.
6. Now notice the date of birth still displays but no age information.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 4 Tomás Cohen Arazi 2023-06-06 13:01:28 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Tomás Cohen Arazi 2023-06-09 14:21:48 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 6 Matt Blenkinsop 2023-06-12 10:58:29 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x