Bug 33902 - On opac-detail.tt the libraryInfoModal is outside of HTML tags
Summary: On opac-detail.tt the libraryInfoModal is outside of HTML tags
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Lucas Gass
QA Contact: David Cook
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-05 22:49 UTC by Lucas Gass
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This moves the HTML for the pop-up window with the information for a library (where it exists) on the OPAC detail page inside the <html> tag so that it validates correctly. There is no change to the appearance or behavior of the page.
Version(s) released in:
23.11.00,23.05.01,22.11.07


Attachments
Bug 33902: Move modal inside HTML body (3.34 KB, patch)
2023-06-05 23:04 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33902: Move modal inside HTML body (3.39 KB, patch)
2023-06-06 01:28 UTC, David Nind
Details | Diff | Splinter Review
Bug 33902: Move modal inside HTML body (3.44 KB, patch)
2023-06-06 05:57 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-06-05 22:49:45 UTC
If you go to OPAC detail and look for the #libraryInfoModal you'll notice it is outside of the <html> tag. Run the HTML through a validator and it will come back with an error.
Comment 1 Lucas Gass 2023-06-05 23:04:47 UTC
Created attachment 152017 [details] [review]
Bug 33902: Move modal inside HTML body

To test:
-Go Administration > Libraries and add a URL for a branch.
-Also add some OPAC info: ( via HTML Customizations )
-Now find a record belonging to that branch and bring up the OPAC detail page.
-In the holdings table there should be a link under the 'Current library' column.
-Clicking it should bring up a modal.
-Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works.

Nothing about the appearance or behavior of the page should change.
Comment 2 David Nind 2023-06-06 01:28:28 UTC
Created attachment 152022 [details] [review]
Bug 33902: Move modal inside HTML body

To test:
-Go Administration > Libraries and add a URL for a branch.
-Also add some OPAC info: ( via HTML Customizations )
-Now find a record belonging to that branch and bring up the OPAC detail page.
-In the holdings table there should be a link under the 'Current library' column.
-Clicking it should bring up a modal.
-Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works.

Nothing about the appearance or behavior of the page should change.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Cook 2023-06-06 05:57:37 UTC
Created attachment 152031 [details] [review]
Bug 33902: Move modal inside HTML body

To test:
-Go Administration > Libraries and add a URL for a branch.
-Also add some OPAC info: ( via HTML Customizations )
-Now find a record belonging to that branch and bring up the OPAC detail page.
-In the holdings table there should be a link under the 'Current library' column.
-Clicking it should bring up a modal.
-Make sure the modal pops up correctly, can be dismissed, and the 'Visit web site' link works.

Nothing about the appearance or behavior of the page should change.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 4 Tomás Cohen Arazi 2023-06-07 18:29:24 UTC
The dependency is not PQA. Can someone check?
Comment 5 Lucas Gass 2023-06-07 18:48:16 UTC
(In reply to Tomás Cohen Arazi from comment #4)
> The dependency is not PQA. Can someone check?

I am removing the dependency. Neither of these patch sets conflict with one another.
Comment 6 Tomás Cohen Arazi 2023-06-07 19:49:39 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Tomás Cohen Arazi 2023-06-09 19:06:15 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Matt Blenkinsop 2023-06-12 11:55:46 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x