Bug 33908 - Improve translation of title tags: Acquisitions
Summary: Improve translation of title tags: Acquisitions
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33906 35422
  Show dependency treegraph
 
Reported: 2023-06-06 15:46 UTC by Owen Leonard
Modified: 2024-03-11 09:35 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33908: Improve translation of title tags: Acquisitions (34.07 KB, patch)
2023-06-07 16:36 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33908: Improve translation of title tags: Acquisitions (34.13 KB, patch)
2023-08-18 08:12 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33908: Improve translation of title tags: Acquisitions (34.19 KB, patch)
2023-08-18 10:15 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 33908: Improve translation of title tags: Acquisitions (34.26 KB, patch)
2023-09-01 09:28 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 15:46:33 UTC
This patch will modify acquisitions, suggestions, and ERM templates so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-06-07 16:36:03 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2023-08-18 08:12:09 UTC
Created attachment 154593 [details] [review]
Bug 33908: Improve translation of title tags: Acquisitions

This patch updates acquisitions, suggestions, and ERM templates so that
title tags can be more easily translated.

To test, apply the patch and confirm that the following pages have the
correct title tags:

 - Acquisitions -> Acquisitions home
   - Ordered
   - Spent
   - Vendors: Search, new, edit
     - Baskets: New, edit
       - New order
         - From an empty record
         - From an existing record
         - From existing orders (copy)
         - From a suggestion
         - From a subscription
         - From an external source
         - From a staged file
     - Basket groups
     - Receive shipments
   - Uncertain prices
   - Late orders
   - Suggestions
   - Invoices
     - Invoice details
       - Invoice files
       - Receive orders
         - Transfer order
         - Cancel order
   - EDIFACT messages
   - Order search
 - ERM
Comment 3 Chris Cormack 2023-08-18 10:15:35 UTC
Created attachment 154632 [details] [review]
Bug 33908: Improve translation of title tags: Acquisitions

This patch updates acquisitions, suggestions, and ERM templates so that
title tags can be more easily translated.

To test, apply the patch and confirm that the following pages have the
correct title tags:

 - Acquisitions -> Acquisitions home
   - Ordered
   - Spent
   - Vendors: Search, new, edit
     - Baskets: New, edit
       - New order
         - From an empty record
         - From an existing record
         - From existing orders (copy)
         - From a suggestion
         - From a subscription
         - From an external source
         - From a staged file
     - Basket groups
     - Receive shipments
   - Uncertain prices
   - Late orders
   - Suggestions
   - Invoices
     - Invoice details
       - Invoice files
       - Receive orders
         - Transfer order
         - Cancel order
   - EDIFACT messages
   - Order search
 - ERM

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 4 Jonathan Druart 2023-09-01 09:28:08 UTC
Created attachment 155080 [details] [review]
Bug 33908: Improve translation of title tags: Acquisitions

This patch updates acquisitions, suggestions, and ERM templates so that
title tags can be more easily translated.

To test, apply the patch and confirm that the following pages have the
correct title tags:

 - Acquisitions -> Acquisitions home
   - Ordered
   - Spent
   - Vendors: Search, new, edit
     - Baskets: New, edit
       - New order
         - From an empty record
         - From an existing record
         - From existing orders (copy)
         - From a suggestion
         - From a subscription
         - From an external source
         - From a staged file
     - Basket groups
     - Receive shipments
   - Uncertain prices
   - Late orders
   - Suggestions
   - Invoices
     - Invoice details
       - Invoice files
       - Receive orders
         - Transfer order
         - Cancel order
   - EDIFACT messages
   - Order search
 - ERM

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-09-01 14:10:19 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-08 05:47:33 UTC
Not backported to 23.05.x