Bug 33910 - Improve translation of title tags: Authorities
Summary: Improve translation of title tags: Authorities
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-06-06 15:50 UTC by Owen Leonard
Modified: 2023-09-19 12:15 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33910: Improve translation of title tags: Authorities (8.09 KB, patch)
2023-06-07 17:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33910: Improve translation of title tags: Authorities (8.13 KB, patch)
2023-06-07 17:46 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 33910: Improve translation of title tags: Authorities (8.20 KB, patch)
2023-08-25 13:33 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33910: (follow-up) Remove mistaken addition of 'USE raw' (864 bytes, patch)
2023-08-25 19:03 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 15:50:20 UTC
This patch will modify authorities templates so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-06-07 17:42:21 UTC
Created attachment 152124 [details] [review]
Bug 33910: Improve translation of title tags: Authorities

This patch updates authorities templates so that title
tags can be more easily translated.

To test, apply the patch and confirm that the following authorities
pages have the correct title tags:

- Authorities -> Authorities home page
  - Authority search results
    - Authority details
      - Edit authority
      - Merge authorities
- Cataloging -> New or edit record
  - Trigger the authority search plugin on a field which is linked to an
    authority type.
Comment 2 Sam Lau 2023-06-07 17:46:43 UTC
Created attachment 152125 [details] [review]
Bug 33910: Improve translation of title tags: Authorities

This patch updates authorities templates so that title
tags can be more easily translated.

To test, apply the patch and confirm that the following authorities
pages have the correct title tags:

- Authorities -> Authorities home page
  - Authority search results
    - Authority details
      - Edit authority
      - Merge authorities
- Cataloging -> New or edit record
  - Trigger the authority search plugin on a field which is linked to an
    authority type.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Katrin Fischer 2023-08-25 13:33:42 UTC
Created attachment 154812 [details] [review]
Bug 33910: Improve translation of title tags: Authorities

This patch updates authorities templates so that title
tags can be more easily translated.

To test, apply the patch and confirm that the following authorities
pages have the correct title tags:

- Authorities -> Authorities home page
  - Authority search results
    - Authority details
      - Edit authority
      - Merge authorities
- Cataloging -> New or edit record
  - Trigger the authority search plugin on a field which is linked to an
    authority type.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-08-25 13:34:19 UTC
Only one little question, why the USE raw?

--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt
@@ -1,7 +1,12 @@
 [% USE To %]
+[% USE raw %]
+[% PROCESS 'i18n.inc' %]
Comment 5 Owen Leonard 2023-08-25 15:06:14 UTC
(In reply to Katrin Fischer from comment #4)
> Only one little question, why the USE raw?

> +[% USE raw %]
> +[% PROCESS 'i18n.inc' %]

Just a copy-paste error I think
Comment 6 Katrin Fischer 2023-08-25 15:38:40 UTC
(In reply to Owen Leonard from comment #5)
> (In reply to Katrin Fischer from comment #4)
> > Only one little question, why the USE raw?
> 
> > +[% USE raw %]
> > +[% PROCESS 'i18n.inc' %]
> 
> Just a copy-paste error I think

Could you provide a quick follow-up to remove that line?
Comment 7 Owen Leonard 2023-08-25 19:03:11 UTC
Created attachment 154848 [details] [review]
Bug 33910: (follow-up) Remove mistaken addition of 'USE raw'
Comment 8 Tomás Cohen Arazi 2023-08-29 17:57:57 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-08-30 07:16:44 UTC
I choose to not backport to stable to avoid too much translation work