Bug 33911 - Improve translation of title tags: Catalog, basket, and lists
Summary: Improve translation of title tags: Catalog, basket, and lists
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-06-06 15:52 UTC by Owen Leonard
Modified: 2023-09-25 12:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33911: Improve translation of title tags: Catalog, basket, and lists (20.81 KB, patch)
2023-06-07 18:26 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33911: Improve translation of title tags: Catalog, basket, and lists (20.86 KB, patch)
2023-09-05 21:11 UTC, David Nind
Details | Diff | Splinter Review
Bug 33911: Improve translation of title tags: Catalog, basket, and lists (20.92 KB, patch)
2023-09-21 21:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33911: Move variables into strings (6.05 KB, patch)
2023-09-21 21:30 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 15:52:13 UTC
This patch will modify catalog, basket, and lists templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-06-07 18:26:07 UTC Comment hidden (obsolete)
Comment 2 David Nind 2023-09-05 21:11:08 UTC Comment hidden (obsolete)
Comment 3 David Nind 2023-09-05 21:17:49 UTC
Testing notes (using KTD):

- MARC preview: wasn't sure how to test this one - normal view for a record > MARC preview > Show - results in a pop-up window with the title "MARC preview", if you right-click on the 'Show' link and open in a new tab, the title is "MARC View" with a plain text rendition of the MARC record.

- Labelled MARC details: set IntranetBiblioDefaultView system preference to 'labelled MARC form', from the search results page this view is displayed.

- Rota: enable the StockRotation system preference for the rota tab to display on the record view.
Comment 4 Katrin Fischer 2023-09-21 21:30:15 UTC
Created attachment 156017 [details] [review]
Bug 33911: Improve translation of title tags: Catalog, basket, and lists

This patch updates catalog, basket, and lists templates so that title
tags can be more easily translated.

To test, apply the patch and confirm that the following pages have the
correct title tags:

 - Advanced search
   - Search results
     - Bibliographic details
       - MARC preview
       - Image viewer (with local cover images)
       - MARC details
       - Labeled MARC details
       - ISBD details
       - Items
       - Checkout history
       - Rota
   - Add titles to the cart and view the cart
     - Send cart
 - Item search
 - Lists
   - View list
   - New list
   - Edit list
   - Send list

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-09-21 21:30:17 UTC
Created attachment 156018 [details] [review]
Bug 33911: Move variables into strings

This has the advantage that translators can tell the full
context and are also able to move the variable if needed
for better grammar.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-09-22 13:55:54 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Fridolin Somers 2023-09-22 19:41:05 UTC
Enhancement not pushed to 23.05.x