Bug 33919 - Improve translation of title tags: Patron clubs
Summary: Improve translation of title tags: Patron clubs
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-06-06 16:06 UTC by Owen Leonard
Modified: 2023-09-25 12:33 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33919: Improve translation of title tags: Patron clubs (6.42 KB, patch)
2023-08-22 13:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33919: Improve translation of title tags: Patron clubs (6.48 KB, patch)
2023-09-12 18:42 UTC, Salah Ghedda
Details | Diff | Splinter Review
Bug 33919: Improve translation of title tags: Patron clubs (6.53 KB, patch)
2023-09-21 21:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 16:06:39 UTC
This patch will modify patron clubs templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-08-22 13:39:19 UTC
Created attachment 154694 [details] [review]
Bug 33919: Improve translation of title tags: Patron clubs

This patch updates patron clubs templates so that title tags can be more
easily translated.

The patch also makes some minor changes to some templates to improve
consistency between page title, breadcrumb navigation, and page heading.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Tools -> Patron clubs
  - New and Edit club template
  - New and Edit club
  - Club enrollments (from the list of clubs choose Actions ->
    Enrollments)
Comment 2 Salah Ghedda 2023-09-12 18:42:03 UTC
Created attachment 155569 [details] [review]
Bug 33919: Improve translation of title tags: Patron clubs

This patch updates patron clubs templates so that title tags can be more
easily translated.

The patch also makes some minor changes to some templates to improve
consistency between page title, breadcrumb navigation, and page heading.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Tools -> Patron clubs
  - New and Edit club template
  - New and Edit club
  - Club enrollments (from the list of clubs choose Actions ->
    Enrollments)

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Comment 3 Katrin Fischer 2023-09-21 21:55:53 UTC
Created attachment 156024 [details] [review]
Bug 33919: Improve translation of title tags: Patron clubs

This patch updates patron clubs templates so that title tags can be more
easily translated.

The patch also makes some minor changes to some templates to improve
consistency between page title, breadcrumb navigation, and page heading.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Tools -> Patron clubs
  - New and Edit club template
  - New and Edit club
  - Club enrollments (from the list of clubs choose Actions ->
    Enrollments)

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Tomás Cohen Arazi 2023-09-22 13:56:01 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-22 19:40:34 UTC
Enhancement not pushed to 23.05.x