Bug 33920 - Improve translation of title tags: Patrons
Summary: Improve translation of title tags: Patrons
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-06-06 16:07 UTC by Owen Leonard
Modified: 2023-09-19 12:18 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33920: Improve translation of title tags: Patrons (35.50 KB, patch)
2023-06-13 15:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33920: Improve translation of title tags: Patrons (35.48 KB, patch)
2023-08-16 10:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33920: Improve translation of title tags: Patrons (35.55 KB, patch)
2023-08-17 10:04 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 33920: Improve translation of title tags: Patrons (35.54 KB, patch)
2023-08-17 12:28 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 16:07:34 UTC
This patch will modify patron module templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-06-13 15:57:37 UTC Comment hidden (obsolete)
Comment 2 Caroline Cyr La Rose 2023-08-16 09:16:54 UTC
OK Patrons home page

   OK Patron search

      OK Merge patron records

   OK Add patron
    
      OK Check duplicate patron

OK Patron details for XX (YY)

   OK API keys

   OK Account for XX (YY)

      OK Details of debit

      -  Details of credit - It was like this before, but it still says 'Details of debit' even when we click on the details button of a payment for example

      OK Print receipt for XX (YY) - improved from before! :)

      -  Print invoice - It was like this before, but the invoice also says 'Print receipt'

      OK Make a payment for XX (YY)

      OK Collect payment for XX (YY)

   OK Create manual invoice 

   OK Create manual credit

OK Subscription routing lists for XX (YY)

OK Circulation history for XX (YY) - improved from before! :)

-  Holds history for XX (YY) - I think this one is missing a > between the name and Patrons

OK Sent notices for XX (YY)

-  Discharge for XX (YY) - There is an extra > between the patron's name and Patrons

OK Statistics for XX (YY)

OK Files for XX (YY) - One > missing between the patron's name and Patrons

OK Purchase suggestions for XX (YY)

OK Details for XX (YY) > Housebound

OK ILL requests history for XX (YY)

OK Set permissions for XX (YY)

-  Update password for XX (YY) - There is an extra > between the patron's name and Patrons

OK Print summary for XX (YY) - improved from before!

OK Account summary for XX (YY)

OK Two-factor authentication

OK Modify patron XX (YY) (ZZ)

OK Choose adult category

OK Delete patron XX (YY) - improved from before! :)

OK Pending discharge requests

OK Update patron records
Comment 3 Caroline Cyr La Rose 2023-08-16 09:18:39 UTC
Hi Owen!

I tested this and there are a couple of things that need to be corrected.

-  Holds history for XX (YY) - I think this one is missing a > between the name and Patrons

-  Discharge for XX (YY) - There is an extra > between the patron's name and Patrons

-  Update password for XX (YY) - There is an extra > between the patron's name and Patrons

Caroline
Comment 4 Owen Leonard 2023-08-16 10:39:07 UTC
Created attachment 154460 [details] [review]
Bug 33920: Improve translation of title tags: Patrons

This patch updates patron module templates so that title
tags can be more easily translated.

To test, apply the patch and confirm that the following patron-related
pages have the correct title tags:

- Patrons home page
  - Patron search ->
    - Select two patrons -> Merge selected
  - Add patron ->
    - Add a patron with the same name and email address ->
      - Click "View existing record" in "Duplicate patron record?"
        dialog.
- Patron details
  - Manage API keys (must have RESTOAuth2ClientCredentials enabled)
  - Accounting
    - Transactions
      - Print fee receipt
      - Print invoice
      - Make a payment
    - Create manual invoice
    - Create manual credit
  - Routing lists (must have RoutingSerials enabled)
  - Circulation history
  - Notices
  - Statistics
  - Files (must have EnableBorrowerFiles enabled)
  - Purchase suggestions
  - Discharges (must have useDischarge enabled)
  - Housebound (must have HouseboundModule enabled)
  - ILL requests history (must have ILLModule enabled)
  - Set permissions
  - Change password
  - Print summary
  - Print account balance
  - Two-factor authentication (must have TwoFactorAuthentication
    enabled)
  - Edit patron
  - Update child to adult patron:
    - Must have more than one "adult" type category defined
    - Locate a patron with a "child" type category
    - Choose More -> Update child to adult patron
  - Delete patron (confirmation page)
- Pending discharge requests
- Patrons requesting modifications
Comment 5 Caroline Cyr La Rose 2023-08-17 10:04:10 UTC
Created attachment 154511 [details] [review]
Bug 33920: Improve translation of title tags: Patrons

This patch updates patron module templates so that title
tags can be more easily translated.

To test, apply the patch and confirm that the following patron-related
pages have the correct title tags:

- Patrons home page
  - Patron search ->
    - Select two patrons -> Merge selected
  - Add patron ->
    - Add a patron with the same name and email address ->
      - Click "View existing record" in "Duplicate patron record?"
        dialog.
- Patron details
  - Manage API keys (must have RESTOAuth2ClientCredentials enabled)
  - Accounting
    - Transactions
      - Print fee receipt
      - Print invoice
      - Make a payment
    - Create manual invoice
    - Create manual credit
  - Routing lists (must have RoutingSerials enabled)
  - Circulation history
  - Notices
  - Statistics
  - Files (must have EnableBorrowerFiles enabled)
  - Purchase suggestions
  - Discharges (must have useDischarge enabled)
  - Housebound (must have HouseboundModule enabled)
  - ILL requests history (must have ILLModule enabled)
  - Set permissions
  - Change password
  - Print summary
  - Print account balance
  - Two-factor authentication (must have TwoFactorAuthentication
    enabled)
  - Edit patron
  - Update child to adult patron:
    - Must have more than one "adult" type category defined
    - Locate a patron with a "child" type category
    - Choose More -> Update child to adult patron
  - Delete patron (confirmation page)
- Pending discharge requests
- Patrons requesting modifications

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 6 Martin Renvoize 2023-08-17 12:28:51 UTC
Created attachment 154558 [details] [review]
Bug 33920: Improve translation of title tags: Patrons

This patch updates patron module templates so that title
tags can be more easily translated.

To test, apply the patch and confirm that the following patron-related
pages have the correct title tags:

- Patrons home page
  - Patron search ->
    - Select two patrons -> Merge selected
  - Add patron ->
    - Add a patron with the same name and email address ->
      - Click "View existing record" in "Duplicate patron record?"
        dialog.
- Patron details
  - Manage API keys (must have RESTOAuth2ClientCredentials enabled)
  - Accounting
    - Transactions
      - Print fee receipt
      - Print invoice
      - Make a payment
    - Create manual invoice
    - Create manual credit
  - Routing lists (must have RoutingSerials enabled)
  - Circulation history
  - Notices
  - Statistics
  - Files (must have EnableBorrowerFiles enabled)
  - Purchase suggestions
  - Discharges (must have useDischarge enabled)
  - Housebound (must have HouseboundModule enabled)
  - ILL requests history (must have ILLModule enabled)
  - Set permissions
  - Change password
  - Print summary
  - Print account balance
  - Two-factor authentication (must have TwoFactorAuthentication
    enabled)
  - Edit patron
  - Update child to adult patron:
    - Must have more than one "adult" type category defined
    - Locate a patron with a "child" type category
    - Choose More -> Update child to adult patron
  - Delete patron (confirmation page)
- Pending discharge requests
- Patrons requesting modifications

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize 2023-08-17 12:29:24 UTC
Great improvement, well worthwhile!

Passing QA
Comment 8 Tomás Cohen Arazi 2023-08-29 17:58:04 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-08-30 07:12:22 UTC
I choose to not backport to stable to avoid too much translation work