Bug 33921 - Improve translation of title tags: Plugins and Point of sale
Summary: Improve translation of title tags: Plugins and Point of sale
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-06-06 16:08 UTC by Owen Leonard
Modified: 2023-09-19 12:18 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33921: Improve translation of title tags: Plugins and Point of sale (8.50 KB, patch)
2023-08-22 14:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33921: Improve translation of title tags: Plugins and Point of sale (8.55 KB, patch)
2023-09-01 09:06 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 33921: Improve translation of title tags: Plugins and Point of sale (8.64 KB, patch)
2023-09-01 12:20 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 16:08:56 UTC
This patch will modify plugin templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-08-22 14:34:23 UTC
Created attachment 154698 [details] [review]
Bug 33921: Improve translation of title tags: Plugins and Point of sale

This patch updates plugin and point of sale templates so
that title tags can be more easily translated.

The patch also makes some minor changes to some templates to improve
consistency between page title, breadcrumb navigation, and page heading.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Administration ->
  - Manage plugins
  - Upload plugin

  * With 'useplugins' set to 0 in koha-conf.xml you can navigate
  directly to /cgi-bin/koha/plugins/plugins-home.pl to confirm that
  the "Plugins disabled" page is shown.

With EnablePointOfSale and UseCashRegisters enabled:

- Point of sale
  - Make a sale and print a receipt for the transaction
  - Transaction history for [register]
  - Cash summary for [library]
Comment 2 Biblibre Sandboxes 2023-09-01 09:06:03 UTC
Created attachment 155070 [details] [review]
Bug 33921: Improve translation of title tags: Plugins and Point of sale

This patch updates plugin and point of sale templates so
that title tags can be more easily translated.

The patch also makes some minor changes to some templates to improve
consistency between page title, breadcrumb navigation, and page heading.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Administration ->
  - Manage plugins
  - Upload plugin

  * With 'useplugins' set to 0 in koha-conf.xml you can navigate
  directly to /cgi-bin/koha/plugins/plugins-home.pl to confirm that
  the "Plugins disabled" page is shown.

With EnablePointOfSale and UseCashRegisters enabled:

- Point of sale
  - Make a sale and print a receipt for the transaction
  - Transaction history for [register]
  - Cash summary for [library]

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Andrew Auld 2023-09-01 09:07:34 UTC
I wasn't able to do the test on the 'Plugins disabled' page as I didn't know how to change the koha-conf.xml file in a sandbox. 
However everything else works great.
Comment 4 Jonathan Druart 2023-09-01 12:20:11 UTC
Created attachment 155109 [details] [review]
Bug 33921: Improve translation of title tags: Plugins and Point of sale

This patch updates plugin and point of sale templates so
that title tags can be more easily translated.

The patch also makes some minor changes to some templates to improve
consistency between page title, breadcrumb navigation, and page heading.

To test, apply the patch and confirm that the following pages have the
correct title tags:

- Administration ->
  - Manage plugins
  - Upload plugin

  * With 'useplugins' set to 0 in koha-conf.xml you can navigate
  directly to /cgi-bin/koha/plugins/plugins-home.pl to confirm that
  the "Plugins disabled" page is shown.

With EnablePointOfSale and UseCashRegisters enabled:

- Point of sale
  - Make a sale and print a receipt for the transaction
  - Transaction history for [register]
  - Cash summary for [library]

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-09-01 14:24:37 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-08 05:56:10 UTC
Not backported to 23.05.x