Bug 33922 - Improve translation of title tags: Recalls
Summary: Improve translation of title tags: Recalls
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-06-06 16:11 UTC by Owen Leonard
Modified: 2023-09-19 12:18 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33922: Improve translation of title tags: Recalls (5.89 KB, patch)
2023-08-23 16:42 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33922: Improve translation of title tags: Recalls (5.94 KB, patch)
2023-09-01 09:26 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33922: Improve translation of title tags: Recalls (6.03 KB, patch)
2023-09-01 12:20 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 16:11:08 UTC
This patch will modify recalls templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-08-23 16:42:33 UTC
Created attachment 154716 [details] [review]
Bug 33922: Improve translation of title tags: Recalls

This patch updates recalls templates so that title tags can be more
easily translated.

To test you must have UseRecalls enabled. Apply the patch and confirm
that the following pages have the correct title tags:

- Circulation ->
  - Recalls queue
  - Recalls to pull
  - Overdue recalls
  - Recalls awaiting pickup
  - Old recalls
- Catalog -> Locate a bibliographic record with an existing recall.
  - View the "Recalls" tab in the sidebar.
Comment 2 ByWater Sandboxes 2023-09-01 09:26:03 UTC
Created attachment 155078 [details] [review]
Bug 33922: Improve translation of title tags: Recalls

This patch updates recalls templates so that title tags can be more
easily translated.

To test you must have UseRecalls enabled. Apply the patch and confirm
that the following pages have the correct title tags:

- Circulation ->
  - Recalls queue
  - Recalls to pull
  - Overdue recalls
  - Recalls awaiting pickup
  - Old recalls
- Catalog -> Locate a bibliographic record with an existing recall.
  - View the "Recalls" tab in the sidebar.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>
Comment 3 Andrew Auld 2023-09-01 09:26:22 UTC
Works beautifully!
Comment 4 Jonathan Druart 2023-09-01 12:20:51 UTC
Created attachment 155110 [details] [review]
Bug 33922: Improve translation of title tags: Recalls

This patch updates recalls templates so that title tags can be more
easily translated.

To test you must have UseRecalls enabled. Apply the patch and confirm
that the following pages have the correct title tags:

- Circulation ->
  - Recalls queue
  - Recalls to pull
  - Overdue recalls
  - Recalls awaiting pickup
  - Old recalls
- Catalog -> Locate a bibliographic record with an existing recall.
  - View the "Recalls" tab in the sidebar.

Signed-off-by: Andrew Auld <andrew.auld@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Tomás Cohen Arazi 2023-09-01 14:24:41 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-08 05:49:35 UTC
Not backported to 23.05.x