Bug 33924 - Improve translation of title tags: Rotating collections
Summary: Improve translation of title tags: Rotating collections
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Lucas Gass
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-06-06 16:15 UTC by Owen Leonard
Modified: 2023-10-14 12:27 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33924: Improve translation of title tags: Rotating collections (7.86 KB, patch)
2023-09-05 15:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33924: Improve translation of title tags: Rotating collections (7.91 KB, patch)
2023-09-12 19:21 UTC, Salah Ghedda
Details | Diff | Splinter Review
Bug 33924: Improve translation of title tags: Rotating collections (7.97 KB, patch)
2023-09-18 16:24 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 16:15:03 UTC
This patch will modify rotating collections templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-09-05 15:57:14 UTC
Created attachment 155226 [details] [review]
Bug 33924: Improve translation of title tags: Rotating collections

This patch updates rotating collection templates so that title tags can
be more easily translated.

The patch also makes some corrections to breadcrumb navigation and page
headers to make sure they are consistent with titles.

To test, apply the patch and confirm that the following rotating
collection pages have the correct title tags:

- Tools -> Rotating collections
  - Rotating collections list
  -> New collection
  -> Edit collection
  -> Delete collection -> Confirmation page
  -> Transfer collection
Comment 2 Salah Ghedda 2023-09-12 19:21:17 UTC
Created attachment 155571 [details] [review]
Bug 33924: Improve translation of title tags: Rotating collections

This patch updates rotating collection templates so that title tags can
be more easily translated.

The patch also makes some corrections to breadcrumb navigation and page
headers to make sure they are consistent with titles.

To test, apply the patch and confirm that the following rotating
collection pages have the correct title tags:

- Tools -> Rotating collections
  - Rotating collections list
  -> New collection
  -> Edit collection
  -> Delete collection -> Confirmation page
  -> Transfer collection

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Comment 3 Lucas Gass 2023-09-18 16:24:55 UTC
Created attachment 155850 [details] [review]
Bug 33924: Improve translation of title tags: Rotating collections

This patch updates rotating collection templates so that title tags can
be more easily translated.

The patch also makes some corrections to breadcrumb navigation and page
headers to make sure they are consistent with titles.

To test, apply the patch and confirm that the following rotating
collection pages have the correct title tags:

- Tools -> Rotating collections
  - Rotating collections list
  -> New collection
  -> Edit collection
  -> Delete collection -> Confirmation page
  -> Transfer collection

Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2023-09-18 18:54:44 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-09-18 21:51:39 UTC
Enhancement not pushed to 23.05.x