Bug 33927 - Improve translation of title tags: Tools
Summary: Improve translation of title tags: Tools
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 33906
  Show dependency treegraph
 
Reported: 2023-06-06 16:16 UTC by Owen Leonard
Modified: 2023-09-25 12:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33927: Improve translation of title tags: Tools (17.30 KB, patch)
2023-09-15 19:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33927: Improve translation of title tags: Tools (17.35 KB, patch)
2023-09-15 19:40 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33927: Improve translation of title tags: Tools (17.41 KB, patch)
2023-09-21 22:01 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-06 16:16:55 UTC
This patch will modify tools templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %]
Comment 1 Owen Leonard 2023-09-15 19:20:05 UTC Comment hidden (obsolete)
Comment 2 Lucas Gass 2023-09-15 19:40:18 UTC
One note for testing. To test "Upload patron images" pages make sure the system preference 'patronimages' is set to 'allow'.
Comment 3 Lucas Gass 2023-09-15 19:40:50 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2023-09-21 22:01:39 UTC
Created attachment 156025 [details] [review]
Bug 33927: Improve translation of title tags: Tools

This patch modifies tools templates so that title tags can be
more easily translated. The patch also makes some modifications to
titles, breadcrumb navigation, and page headers in order to make them
more consistent with each other and with other similar pages.

To test, apply the patch and go to Tools. Test each of the following
pages and each variation of the page to confirm that titles,
breadcrumbs, and page headers look correct.

- Tools home page
- Import patrons
  - Import results
- Notices and slips
  - Main page
    - Main page filtered by library
    - New notice
    - Edit notice
      - Preview notice: With a CHECKIN, CHECKOUT, or HOLD_SLIP notice,
        fill in the "Data for preview" box in the "Email" section.
        Although the template loads in a modal window which doesn't show
        the page title, you can confirm that there are no errors.
- Overdue notice/status triggers
- Batch patron deletion
  - Confirmation page
- Batch patron modification
- Batch extend due dates
- Upload patron images

Print notices: With useDischarge enabled, log into the OPAC as a
user with no checkouts. Go to the "Ask for a discharge" tab and click
"Ask for a discharge."

Locate the patron's record in the staff interface and click "Discharges"
in the left-hand sidebar menu. Click "Generate discharge." Open the
resulting PDF file in a browser. The page title should be "Print notices
for [date]."

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Tomás Cohen Arazi 2023-09-22 13:56:05 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Fridolin Somers 2023-09-22 19:40:46 UTC
Enhancement not pushed to 23.05.x