Bug 33935 - Installer list deleted files which shows warning in the logs
Summary: Installer list deleted files which shows warning in the logs
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 26403
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-07 09:18 UTC by Jonathan Druart
Modified: 2023-12-28 20:47 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.01,22.11.07


Attachments
Bug 33935: (bug 26403 follow-up) Remove occurrences to deleted files (1.33 KB, patch)
2023-06-07 09:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33935: (bug 26403 follow-up) Remove occurrences to deleted files (1.40 KB, patch)
2023-06-07 11:53 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-06-07 09:18:10 UTC
account_credit_types.sql and account_debit_types.sql have been moved to yml files but there are still references to them in C4::Installer.

If you select the files during the installer process it will explode with

 Something went wrong loading file /usr/share/koha/intranet/cgi-bin/installer/data/mysql/mandatory/account_credit_types.sql (Couldn't read '/usr/share/koha/intranet/cgi-bin/installer/data/mysql/mandatory/account_credit_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 180. ) at /usr/share/koha/lib/C4/Installer.pm line 587.
Comment 1 Jonathan Druart 2023-06-07 09:19:50 UTC
Created attachment 152082 [details] [review]
Bug 33935: (bug 26403 follow-up) Remove occurrences to deleted files

account_credit_types.sql and account_debit_types.sql have been moved to yml files but there are still references to them in C4::Installer.

If you select the files during the installer process it will explode with

Test plan:
DROP database koha_kohadev
CREATE database koha_kohadev
restart_all
then install Koha using the UI
Select all the sample data files
Comment 2 David Nind 2023-06-07 10:45:20 UTC
I can't recreate the issue using KTD - nothing explodes after selecting all the sample data and clicking import.

(How I reset the database in KTD https://gitlab.com/-/snippets/1893788#start-the-web-installer)
Comment 3 Jonathan Druart 2023-06-07 11:20:34 UTC
Indeed wrong description it actually does not explode, but there is the error in the plack-intranet-error.log file

[WARN] Something went wrong loading file /kohadevbox/koha/installer/data/mysql/mandatory/account_credit_types.sql (Couldn't read '/kohadevbox/koha/installer/data/mysql/mandatory/account_credit_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 180.
) at /kohadevbox/koha/C4/Installer.pm line 588.

[WARN] Something went wrong loading file /kohadevbox/koha/installer/data/mysql/mandatory/account_debit_types.sql (Couldn't read '/kohadevbox/koha/installer/data/mysql/mandatory/account_debit_types.sql' : No such file or directory at /usr/share/perl5/DBIx/RunSQL.pm line 180.
) at /kohadevbox/koha/C4/Installer.pm line 588.

lowering severity
Comment 4 Martin Renvoize 2023-06-07 11:53:13 UTC
Created attachment 152099 [details] [review]
Bug 33935: (bug 26403 follow-up) Remove occurrences to deleted files

account_credit_types.sql and account_debit_types.sql have been moved to yml files but there are still references to them in C4::Installer.

If you select the files during the installer process it will explode with

Test plan:
DROP database koha_kohadev
CREATE database koha_kohadev
restart_all
then install Koha using the UI
Select all the sample data files

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2023-06-07 11:54:17 UTC
Thanks for the quick follow-up here Jonathan.. annoyed I missed this one :(
Comment 6 Tomás Cohen Arazi 2023-06-07 18:34:17 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 David Nind 2023-06-07 22:03:45 UTC
(In reply to Jonathan Druart from comment #3)
> Indeed wrong description it actually does not explode, but there is the
> error in the plack-intranet-error.log file

Thanks Jonathan!
Comment 8 Matt Blenkinsop 2023-06-12 11:56:34 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x