Bug 33950 - Unnecessary processing in opac-readingrec if BakerTaylor and Syndetics off
Summary: Unnecessary processing in opac-readingrec if BakerTaylor and Syndetics off
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 33746
  Show dependency tree / graph
 
Reported: 2023-06-08 08:14 UTC by Jonathan Druart
Modified: 2023-12-28 20:46 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Circulation function:

Attachments
Bug 33950: Don't get marcxml if not necessary - opac-readingrecord.pl (2.16 KB, patch)
2023-06-08 08:16 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 33950: Don't get marcxml if not necessary - opac-readingrecord.pl (2.22 KB, patch)
2023-06-08 10:44 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-06-08 08:14:17 UTC 
We are retrieving normalized_upc from the MARC XML in the controller (opac-readingrec.pl) for all issues to display, but this is only used if BakerTaylor or Syndetics are enabled.
Comment 1 Jonathan Druart 2023-06-08 08:16:11 UTC 
Created attachment 152140 [details] [review]
Bug 33950: Don't get marcxml if not necessary - opac-readingrecord.pl

We are retrieving normalized_upc from the MARC XML in the controller (opac-readingrec.pl)
for all issues to display, but this is only used if BakerTaylor or Syndetics are enabled.

Test plan:
Have some checkouts and confirm that the checkout history is displayed
the same before and after this patch.
You should also test BakerTaylor or Syndetics and see if they are
working correctly, but I have no idea how to test them!
Comment 2 Nick Clemens (kidclamp) 2023-06-08 10:44:33 UTC 
Created attachment 152144 [details] [review]
Bug 33950: Don't get marcxml if not necessary - opac-readingrecord.pl

We are retrieving normalized_upc from the MARC XML in the controller (opac-readingrec.pl)
for all issues to display, but this is only used if BakerTaylor or Syndetics are enabled.

Test plan:
Have some checkouts and confirm that the checkout history is displayed
the same before and after this patch.
You should also test BakerTaylor or Syndetics and see if they are
working correctly, but I have no idea how to test them!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 3 Nick Clemens (kidclamp) 2023-06-08 10:44:47 UTC 
Trivial and straightforward, passing QA
Comment 4 Tomás Cohen Arazi (tcohen) 2023-06-08 11:33:38 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize (ashimema) 2023-07-12 07:01:57 UTC 
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 6 Matt Blenkinsop 2023-07-12 09:17:07 UTC 
Nice work everyone!

Pushed to oldstable for 22.11.x