Bug 33961 - In-built Offline circulation tool no longer working and should be removed
Summary: In-built Offline circulation tool no longer working and should be removed
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 22671
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-08 14:41 UTC by Jonathan Druart
Modified: 2024-01-17 15:31 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact: Caroline Cyr La Rose
Documentation submission: https://gitlab.com/koha-community/koha-manual/-/merge_requests/815
Text to go in the release notes:
This removed the in-built Koha offline circulation tool that could be activated using the AllowOfflineCirculation system preference. This won't have any effect on the KOCT Firefox plugin or on the Windows desktop offline circulation tool.
Version(s) released in:
23.11.00,23.05.02


Attachments
Bug 33961: Remove built-in offline circ tool (75.91 KB, patch)
2023-06-08 15:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33961: Remove built-in offline circ tool (76.89 KB, patch)
2023-06-08 15:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33961: Remove built-in offline circ tool (76.94 KB, patch)
2023-06-09 10:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33961: Remove built-in offline circ tool (76.99 KB, patch)
2023-06-09 11:57 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-06-08 14:41:35 UTC
The tool has not been updated and is no longer working with modern browser.
It should either be rewritten/adjusted or removed. Given that we didn't get complains its non-functional status, bugs related to this tool didn't get attention, and the community is lacking resources, I am suggesting to remove it and redirect users to the koct FF plugin that is known to be working.
Comment 1 Jonathan Druart 2023-06-08 14:43:13 UTC
And the desktop app for windows users.
Comment 2 Jonathan Druart 2023-06-08 14:44:17 UTC
And this thread on the devel ML
https://lists.koha-community.org/pipermail/koha-devel/2021-August/046672.html
Comment 3 Jonathan Druart 2023-06-08 15:50:42 UTC
Created attachment 152209 [details] [review]
Bug 33961: Remove built-in offline circ tool

The tool has not been updated and is no longer working with modern browser.
It should either be rewritten/adjusted or removed. Given that we didn't get complains its non-functional status, bugs related to this tool didn't get attention, and the community is lacking resources, I am suggesting to remove it and redirect users to the koct FF plugin that is known to be working.

Test plan:
See bug 10240 and use `git grep` to confirm that we are removing all
tracks of this feature.
Comment 4 Jonathan Druart 2023-06-08 15:57:23 UTC
Created attachment 152210 [details] [review]
Bug 33961: Remove built-in offline circ tool

The tool has not been updated and is no longer working with modern browser.
It should either be rewritten/adjusted or removed. Given that we didn't get complains its non-functional status, bugs related to this tool didn't get attention, and the community is lacking resources, I am suggesting to remove it and redirect users to the koct FF plugin that is known to be working.

Test plan:
See bug 10240 and use `git grep` to confirm that we are removing all
tracks of this feature.
Comment 5 Owen Leonard 2023-06-09 10:41:30 UTC
Created attachment 152237 [details] [review]
Bug 33961: Remove built-in offline circ tool

The tool has not been updated and is no longer working with modern
browser.

It should either be rewritten/adjusted or removed. Given that we didn't
get complains its non-functional status, bugs related to this tool
didn't get attention, and the community is lacking resources, I am
suggesting to remove it and redirect users to the koct FF plugin that
is known to be working.

Test plan:
See bug 10240 and use `git grep` to confirm that we are removing all
tracks of this feature.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Katrin Fischer 2023-06-09 11:57:50 UTC
Created attachment 152243 [details] [review]
Bug 33961: Remove built-in offline circ tool

The tool has not been updated and is no longer working with modern
browser.

It should either be rewritten/adjusted or removed. Given that we didn't
get complains its non-functional status, bugs related to this tool
didn't get attention, and the community is lacking resources, I am
suggesting to remove it and redirect users to the koct FF plugin that
is known to be working.

Test plan:
See bug 10240 and use `git grep` to confirm that we are removing all
tracks of this feature.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 7 Tomás Cohen Arazi 2023-06-12 18:46:28 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Martin Renvoize 2023-07-17 07:22:33 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 9 Pedro Amorim 2023-07-18 10:51:43 UTC
Not pushing to 22.11.x
Comment 11 Caroline Cyr La Rose 2024-01-17 15:31:43 UTC
In accordance with the "one manual (to rule them all)", I only added a bunch of notes to indicate that this was deprecated, rather than removing the section.