Bug 33962 - Remove C4::BackgroundJob from process_koc
Summary: Remove C4::BackgroundJob from process_koc
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 2608
Blocks: 33963
  Show dependency tree / graph
 
Reported: 2023-06-08 15:35 UTC by Jonathan Druart
Modified: 2024-07-04 20:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00
Circulation function:

Attachments
Bug 33962: Remove background job from process koc (7.64 KB, patch)
2023-06-08 15:40 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 33962: Remove background job from process koc (7.70 KB, patch)
2023-06-15 08:45 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Bug 33962: Remove background job from process koc (7.76 KB, patch)
2023-06-15 11:11 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-06-08 15:35:47 UTC 
The last occurrence of C4::BackgroundJob is in process_koc.pl that is used to upload a file.
Added by bug 2608 (15 years ago), I think it does not longer make sense as networks are faster, and we should not expect big koc files to be uploaded.
If there are complains we will move it to Koha::BackgroundJob.
Comment 1 Jonathan Druart 2023-06-08 15:40:01 UTC 
Created attachment 152206 [details] [review]
Bug 33962: Remove background job from process koc

The last occurrence of C4::BackgroundJob is in process_koc.pl that is used to upload a file.
Added by bug 2608 (15 years ago), I think it does not longer make sense as networks are faster, and we should not expect big koc files to be uploaded.
If there are complains we will move it to Koha::BackgroundJob.

Test plan:
Upload a koc file, enqueue the operations and confirm that everything is
working correctly
Comment 2 Martin Renvoize (ashimema) 2023-06-15 08:45:06 UTC 
Created attachment 152373 [details] [review]
Bug 33962: Remove background job from process koc

The last occurrence of C4::BackgroundJob is in process_koc.pl that is used to upload a file.
Added by bug 2608 (15 years ago), I think it does not longer make sense as networks are faster, and we should not expect big koc files to be uploaded.
If there are complains we will move it to Koha::BackgroundJob.

Test plan:
Upload a koc file, enqueue the operations and confirm that everything is
working correctly

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2023-06-15 08:45:47 UTC 
Makes sense to me
Comment 4 Tomás Cohen Arazi (tcohen) 2023-06-15 11:11:07 UTC 
Created attachment 152376 [details] [review]
Bug 33962: Remove background job from process koc

The last occurrence of C4::BackgroundJob is in process_koc.pl that is used to upload a file.
Added by bug 2608 (15 years ago), I think it does not longer make sense as networks are faster, and we should not expect big koc files to be uploaded.
If there are complains we will move it to Koha::BackgroundJob.

Test plan:
Upload a koc file, enqueue the operations and confirm that everything is
working correctly

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 5 Tomás Cohen Arazi (tcohen) 2023-06-15 11:49:12 UTC 
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Martin Renvoize (ashimema) 2023-07-17 12:08:22 UTC 
Leaving out of 23.05.x branch for now.