In Bug 24279, we disabled the "Claims Returned" option in the Lost status drop-down in moredetail.pl, because the claims returned feature does not work correctly if the status is set in that way. However, if an item already has a different Lost status, the "Claims Returned" option is selectable, although it should not be.
Created attachment 152264 [details] [review] Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected Prevent "claims returned" from being selectable from moredetail.pl, even if another lost status is already set To test: 1. Configure Claims returned i. Go to Administration > Authorized Values > LOST ii. Add a new authorized value with value:6 and description:Claims returned iii. Go to Administration > System Preferences iv. Set ClaimReturnedLostValue to 6 and save 2. Go to any title record and click the barcode for any item 3. Click the Lost status drop-down. Note that the Claims Returned option is disabled. 4. Select a Lost status and click "Set status" 5. Click the Lost status drop-down. Note that the Claims Returned option is now selectable. 6. Apply the patch and refresh the page 7. Note that the Claims Returned option is now disabled. 8. Find a different item and check it out to a customer. 9. On that customer's account, click "Claim Returned" for that item 10. Click the barcode to view moredetail for that item Note that the Lost status drop-down is disabled with Claims Returned selected
Created attachment 152345 [details] [review] Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected Prevent "claims returned" from being selectable from moredetail.pl, even if another lost status is already set To test: 1. Configure Claims returned i. Go to Administration > Authorized Values > LOST ii. Add a new authorized value with value:6 and description:Claims returned iii. Go to Administration > System Preferences iv. Set ClaimReturnedLostValue to 6 and save 2. Go to any title record and click the barcode for any item 3. Click the Lost status drop-down. Note that the Claims Returned option is disabled. 4. Select a Lost status and click "Set status" 5. Click the Lost status drop-down. Note that the Claims Returned option is now selectable. 6. Apply the patch and refresh the page 7. Note that the Claims Returned option is now disabled. 8. Find a different item and check it out to a customer. 9. On that customer's account, click "Claim Returned" for that item 10. Click the barcode to view moredetail for that item Note that the Lost status drop-down is disabled with Claims Returned selected Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 152681 [details] [review] Bug 33976: Disable claims returned option in moredetail.pl when another lost status is selected Prevent "claims returned" from being selectable from moredetail.pl, even if another lost status is already set To test: 1. Configure Claims returned i. Go to Administration > Authorized Values > LOST ii. Add a new authorized value with value:6 and description:Claims returned iii. Go to Administration > System Preferences iv. Set ClaimReturnedLostValue to 6 and save 2. Go to any title record and click the barcode for any item 3. Click the Lost status drop-down. Note that the Claims Returned option is disabled. 4. Select a Lost status and click "Set status" 5. Click the Lost status drop-down. Note that the Claims Returned option is now selectable. 6. Apply the patch and refresh the page 7. Note that the Claims Returned option is now disabled. 8. Find a different item and check it out to a customer. 9. On that customer's account, click "Claim Returned" for that item 10. Click the barcode to view moredetail for that item Note that the Lost status drop-down is disabled with Claims Returned selected Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Working as expected and change makes logical sense. Passing QA
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to 22.11.x for next release