Bug 33998 - Installer and onboarding have incorrect Font Awesome asset links
Summary: Installer and onboarding have incorrect Font Awesome asset links
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 32910
Blocks:
  Show dependency treegraph
 
Reported: 2023-06-13 16:15 UTC by Owen Leonard
Modified: 2023-07-17 10:02 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 33998: Installer and onboarding have incorrect Font Awesome asset links (1.83 KB, patch)
2023-06-13 16:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33998: Installer and onboarding have incorrect Font Awesome asset links (1.89 KB, patch)
2023-06-13 19:58 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 33998: Installer and onboarding have incorrect Font Awesome asset links (1.96 KB, patch)
2023-06-14 10:35 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-13 16:15:00 UTC
Bug 32910 missed updating the installer-doc-head-close.inc file. It needs to be updated to point to the correct assets.
Comment 1 Owen Leonard 2023-06-13 16:22:16 UTC
Created attachment 152310 [details] [review]
Bug 33998: Installer and onboarding have incorrect Font Awesome asset links

This patch corrects the Font Awesome asset links in the web installer.
They were not updated during the upgrade to Font Awesome 6.

Unrelated: The patch also removes the inclusion of jQueryUI. It is not
used in the installation or onboarding process.

To test, apply the patch and run the web installer. The display of
installation steps should include square icons indicating which steps
are complete.
Comment 2 Lucas Gass 2023-06-13 19:58:51 UTC
Created attachment 152325 [details] [review]
Bug 33998: Installer and onboarding have incorrect Font Awesome asset links

This patch corrects the Font Awesome asset links in the web installer.
They were not updated during the upgrade to Font Awesome 6.

Unrelated: The patch also removes the inclusion of jQueryUI. It is not
used in the installation or onboarding process.

To test, apply the patch and run the web installer. The display of
installation steps should include square icons indicating which steps
are complete.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Jonathan Druart 2023-06-14 10:35:10 UTC
Created attachment 152330 [details] [review]
Bug 33998: Installer and onboarding have incorrect Font Awesome asset links

This patch corrects the Font Awesome asset links in the web installer.
They were not updated during the upgrade to Font Awesome 6.

Unrelated: The patch also removes the inclusion of jQueryUI. It is not
used in the installation or onboarding process.

To test, apply the patch and run the web installer. The display of
installation steps should include square icons indicating which steps
are complete.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Tomás Cohen Arazi 2023-06-14 12:24:41 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-07-17 10:02:38 UTC
Depends on 32910 not pushed to 23.05.x