On the bibliographic detail page for a serial record, under the "Subscriptions" tab, there is a link to "Subscription details." This link takes the user to the Serials module, so it should not be displayed if the user doesn't have the correct permission.
Created attachment 152314 [details] [review] Bug 33999: Subscription details link on bibliographic detail page should have permission check This patch wraps the "Subscription details" link on the bibliographic detail page with a permissions check, "CAN_user_serials," so that a user lacking permission to access the Serials module will not be shown the link. To test, apply the patch and view the bibliographic detail page of a serial record. - When viewing the "Subscriptions" tab as a user with Serials permissions you should see the "Subscription details" link. - When viewing the tab as a user without the correct permissions the link should not be present.
Created attachment 152320 [details] [review] Bug 33999: Subscription details link on bibliographic detail page should have permission check This patch wraps the "Subscription details" link on the bibliographic detail page with a permissions check, "CAN_user_serials," so that a user lacking permission to access the Serials module will not be shown the link. To test, apply the patch and view the bibliographic detail page of a serial record. - When viewing the "Subscriptions" tab as a user with Serials permissions you should see the "Subscription details" link. - When viewing the tab as a user without the correct permissions the link should not be present. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
The permission check is correct of course, but I am not sure about turning this into a button. For me a button means "action", but here it's "navigation". Owen, what do you think?
Created attachment 152687 [details] [review] Bug 33999: (follow-up) Use link-styled button
Created attachment 152977 [details] [review] Bug 33999: Subscription details link on bibliographic detail page should have permission check This patch wraps the "Subscription details" link on the bibliographic detail page with a permissions check, "CAN_user_serials," so that a user lacking permission to access the Serials module will not be shown the link. To test, apply the patch and view the bibliographic detail page of a serial record. - When viewing the "Subscriptions" tab as a user with Serials permissions you should see the "Subscription details" link. - When viewing the tab as a user without the correct permissions the link should not be present. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 152978 [details] [review] Bug 33999: (follow-up) Use link-styled button Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice catch, Passing QA
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x