Bug 34015 - Terminology: Relative issues should be Relative's checkouts
Summary: Terminology: Relative issues should be Relative's checkouts
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Caroline Cyr La Rose
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-14 20:54 UTC by Caroline Cyr La Rose
Modified: 2023-12-28 20:47 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08
Circulation function:


Attachments
Bug 34015 - Terminology: Relative issues should be Relative's checkouts (2.24 KB, patch)
2023-06-15 14:09 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 34015: Terminology: Relative issues should be Relative's checkouts (2.30 KB, patch)
2023-06-15 15:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34015: Terminology: Relative issues should be Relative's checkouts (2.35 KB, patch)
2023-06-22 20:09 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2023-06-14 20:54:45 UTC
I found this string while translating. It seems to be a string for screen readers only. But I think it should still follow terminology.

The string is in opac-user.tt, around line 670.

<caption class="sr-only">Relative issues</caption>

It's for the tab that shows Relatives' checkouts.
Comment 1 Caroline Cyr La Rose 2023-06-15 14:09:16 UTC
Created attachment 152384 [details] [review]
Bug 34015 - Terminology: Relative issues should be Relative's checkouts

This patch changes the term 'issues' in a screen reader caption in the
OPAC to the correct term 'checkouts'.

To test:
Setup:
- Have a patron with a guarantee
- Check out an item to the guarantee
- Make sure the guarantee allows their guarantor to see their checkouts
  (AllowStaffToSetCheckoutsVisibilityForGuarantor must be on for you to
be able to set this)

1. In the OPAC, log in with the guarantor patron
2. Click on the Relatives' checkouts tab
3. Open a screen reader (in Ubuntu, Super + Alt + S to turn on/off)
4. Navigate to the table in the Relative's checkouts tab
   --> The screen reader should say 'Relative issue table with...'
5. Apply patch
6. Refresh the page
7. Restart the screen reader (if it was off)
   --> The screen reader should now say 'Relatives' checkouts table
with...'

Alternatively, open the page inspector and inspect the table, the
caption is in the table tag, before the thead tag.
Comment 2 Owen Leonard 2023-06-15 15:24:29 UTC
Created attachment 152387 [details] [review]
Bug 34015: Terminology: Relative issues should be Relative's checkouts

This patch changes the term 'issues' in a screen reader caption in the
OPAC to the correct term 'checkouts'.

To test:
Setup:
- Have a patron with a guarantee
- Check out an item to the guarantee
- Make sure the guarantee allows their guarantor to see their checkouts
  (AllowStaffToSetCheckoutsVisibilityForGuarantor must be on for you to
  be able to set this)

1. In the OPAC, log in with the guarantor patron
2. Click on the Relatives' checkouts tab
3. Open a screen reader (in Ubuntu, Super + Alt + S to turn on/off)
4. Navigate to the table in the Relative's checkouts tab
   --> The screen reader should say 'Relative issue table with...'
5. Apply patch
6. Refresh the page
7. Restart the screen reader (if it was off)
   --> The screen reader should now say 'Relatives' checkouts table
   with...'

Alternatively, open the page inspector and inspect the table, the
caption is in the table tag, before the thead tag.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Katrin Fischer 2023-06-22 20:09:37 UTC
Created attachment 152586 [details] [review]
Bug 34015: Terminology: Relative issues should be Relative's checkouts

This patch changes the term 'issues' in a screen reader caption in the
OPAC to the correct term 'checkouts'.

To test:
Setup:
- Have a patron with a guarantee
- Check out an item to the guarantee
- Make sure the guarantee allows their guarantor to see their checkouts
  (AllowStaffToSetCheckoutsVisibilityForGuarantor must be on for you to
  be able to set this)

1. In the OPAC, log in with the guarantor patron
2. Click on the Relatives' checkouts tab
3. Open a screen reader (in Ubuntu, Super + Alt + S to turn on/off)
4. Navigate to the table in the Relative's checkouts tab
   --> The screen reader should say 'Relative issue table with...'
5. Apply patch
6. Refresh the page
7. Restart the screen reader (if it was off)
   --> The screen reader should now say 'Relatives' checkouts table
   with...'

Alternatively, open the page inspector and inspect the table, the
caption is in the table tag, before the thead tag.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Katrin Fischer 2023-06-22 20:10:28 UTC
I tried to find other similar strings in the templates, but couldn't find any. Thx Caroline!
Comment 5 Tomás Cohen Arazi (tcohen) 2023-06-23 14:04:00 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 6 Martin Renvoize (ashimema) 2023-07-17 14:36:00 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 7 Pedro Amorim 2023-07-18 11:55:05 UTC
Nice work everyone!

Pushed to 22.11.x for next release