On the serials-collection.pl page, there is a same-directory relative link to "subscription-detail.pl" under the "Subscription num." column. Most of the time this isn't a problem, but when you delete a serial, it sends you to a URL like this: http://localhost:8081/cgi-bin/koha/serials/serials-collection.pl/?op=delete_confirmed&biblionumber=1&subscriptionid=1&serialid=1# That relative URL will be interpreted as the following: http://localhost:8081/cgi-bin/koha/serials/serials-collection.pl/subscription-detail.pl?subscriptionid=1 Instead of generating an error, this actually loads the http://localhost:8081/cgi-bin/koha/serials/serials-collection.pl page. The /subscription-detail.pl would be just added to the PATH_INFO on the server. The solution is to use a root-relative URL like we do everywhere else (e.g. /cgi-bin/koha/serials/subscription-detail.pl)
Created attachment 152459 [details] [review] Bug 34052: Use root relative URL for subscription-detail.pl This patch replaces a same directory relative URL with a root relative URL, so that the navigation to subscription-detail.pl works correctly after deleting a serial. To test: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 2. Click "New subscription" 3. Click "Search for a vendor" 4. Click "OK" 5. Click "Choose" 6. Click "Search for record" 7. Type "e" into "Keyword:" box 8. Click "Search" 9. Click "Choose" on top result 10. Click "Next" 11. Fill in "Serials planning" however you like, and click "Test prediction pattern" 12. Click "Save subscription" 13. Click "Serial collection" in left nav menu 14. Click "Delete selected issues" 15. Click "Yes, delete" 16. Click the link under the "Subscription num." table column 17. Note that you're taken to the subscription detail page
Created attachment 152493 [details] [review] Bug 34052: Use root relative URL for subscription-detail.pl This patch replaces a same directory relative URL with a root relative URL, so that the navigation to subscription-detail.pl works correctly after deleting a serial. To test: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 2. Click "New subscription" 3. Click "Search for a vendor" 4. Click "OK" 5. Click "Choose" 6. Click "Search for record" 7. Type "e" into "Keyword:" box 8. Click "Search" 9. Click "Choose" on top result 10. Click "Next" 11. Fill in "Serials planning" however you like, and click "Test prediction pattern" 12. Click "Save subscription" 13. Click "Serial collection" in left nav menu 14. Click "Delete selected issues" 15. Click "Yes, delete" 16. Click the link under the "Subscription num." table column 17. Note that you're taken to the subscription detail page Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 152591 [details] [review] Bug 34052: Use root relative URL for subscription-detail.pl This patch replaces a same directory relative URL with a root relative URL, so that the navigation to subscription-detail.pl works correctly after deleting a serial. To test: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 2. Click "New subscription" 3. Click "Search for a vendor" 4. Click "OK" 5. Click "Choose" 6. Click "Search for record" 7. Type "e" into "Keyword:" box 8. Click "Search" 9. Click "Choose" on top result 10. Click "Next" 11. Fill in "Serials planning" however you like, and click "Test prediction pattern" 12. Click "Save subscription" 13. Click "Serial collection" in left nav menu 14. Click "Delete selected issues" 15. Click "Yes, delete" 16. Click the link under the "Subscription num." table column 17. Note that you're taken to the subscription detail page Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Technically the bug description was correct, but I think we can make it a little more telling to users :)
Created attachment 152592 [details] [review] Bug 34052: Use root relative URL for subscription-detail.pl This patch replaces a same directory relative URL with a root relative URL, so that the navigation to subscription-detail.pl works correctly after deleting a serial. To test: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/serials/serials-home.pl 2. Click "New subscription" 3. Click "Search for a vendor" 4. Click "OK" 5. Click "Choose" 6. Click "Search for record" 7. Type "e" into "Keyword:" box 8. Click "Search" 9. Click "Choose" on top result 10. Click "Next" 11. Fill in "Serials planning" however you like, and click "Test prediction pattern" 12. Click "Save subscription" 13. Click "Serial collection" in left nav menu 14. Click "Delete selected issues" 15. Click "Yes, delete" 16. Click the link under the "Subscription num." table column 17. Note that you're taken to the subscription detail page Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to 22.11.x for next release