Bug 34074 - Improve translations of strings on the about page
Summary: Improve translations of strings on the about page
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-21 11:32 UTC by Owen Leonard
Modified: 2023-12-28 20:47 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 34074: Improve translations of strings on the about page (9.71 KB, patch)
2023-06-21 11:56 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34074: Improve translations of strings on the about page (9.75 KB, patch)
2023-06-29 16:13 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34074: Improve translations of strings on the about page (9.83 KB, patch)
2023-07-07 06:53 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-06-21 11:32:45 UTC
The about page has a lot of complex translation problems, but some can be addressed fairly easily by wrapping strings with <span>.
Comment 1 Owen Leonard 2023-06-21 11:56:44 UTC
Created attachment 152517 [details] [review]
Bug 34074: Improve translations of strings on the about page

This patch makes a few simple changes to the about page template to
improve how the translation tool picks up strings to translate.

The patch also corrects a couple of lines where template tags contained
line breaks.

To test, apply the patch and view the about page in the staff interface.
Everything should look correct.
Comment 2 Sam Lau 2023-06-29 16:13:06 UTC
Created attachment 152873 [details] [review]
Bug 34074: Improve translations of strings on the about page

This patch makes a few simple changes to the about page template to
improve how the translation tool picks up strings to translate.

The patch also corrects a couple of lines where template tags contained
line breaks.

To test, apply the patch and view the about page in the staff interface.
Everything should look correct.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Jonathan Druart 2023-07-07 06:53:45 UTC
Created attachment 153116 [details] [review]
Bug 34074: Improve translations of strings on the about page

This patch makes a few simple changes to the about page template to
improve how the translation tool picks up strings to translate.

The patch also corrects a couple of lines where template tags contained
line breaks.

To test, apply the patch and view the about page in the staff interface.
Everything should look correct.

Signed-off-by: Sam Lau <samalau@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Tomás Cohen Arazi 2023-07-07 12:18:55 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-07-18 09:12:03 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 6 Matt Blenkinsop 2023-07-18 13:46:34 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x