A few templates in the OPAC still define a string in one place and then use the string in another. If the string is used only once I don't think it's necessary to separate the definition from the use.
Hi Owen, you did a lot of work on moving the JS/template strings lately, is this one still needed?
Created attachment 159521 [details] [review] Bug 34082: Cut some redundancy in OPAC JavaScript string translations This patch consolidates some JS code so that we're not defining a string ine one place and using it once elsewhere. With JS-friendly translations tools we don't need this workaround. To test, apply the patch and go to Administration -> Circulation and fine rules. - Configure an item type rule with the "OPAC item level holds" setting set to "Force." - Log in to the OPAC and locate a record with that item type and multiple items. An example in the sample data: /cgi-bin/koha/opac-detail.pl?biblionumber=12 - Place a hold on the item. - The holds screen should show a table of items. - Open your browser's developer tools. - In the Console tab, paste in this code and hit ENTER. - All radio buttons in the table of items should be cleared. - Click the "Confirm hold" button. You should get an alert: "Expecting a specific item selection." - Log in to the OPAC and click the "Search history" tab from the user summary page. - Check one or more checkboxes next to search history items and click the "Remove selected searches." - You should get an alert: "Are you sure you want to delete selected search history entries?" - Log in to the OPAC, create a new list if necessary, and add some titles to the list. - Test that confirmation messages show correctly: - Deleting a single title by clicking the "Remove from this list" link. - Deleting multiple titles by checking boxes and clicking "Remove from list." - Deleting a list. - In Administration -> System preferences, enable TagsEnabled if necessary. - Log in to the OPAC and tag one or more items. - From the Tag cloud page, check one or more boxes for your tags, and click the "Delete selected tags" button at the bottom of the page. - The confirmation message should display correctly. - To test the change to opac-account.tt you have to install a payment plugin, e.g. https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal, and attempt to submit a payment which is below the minimum payment threshold set in the plugin's configuration.
Two things I couldn't test: 1. Circulation and fine rules: "In the Console tab, paste in this code and hit ENTER." There is no code provided to enter into the console. 2. Payment plugin: in the current master, the PayPal plugin doesn't work - if you go to configure, you get a screen with nothing in the content area, you can no longer click on any navigation links, and there are errors in the console.[1] Is there another payment plugin to try? [1] Errors in the console: GET http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/77c7724cb7b76d9c6f1f.js [HTTP/1.1 404 Not Found 333ms] GET http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/b50d36cd3cebca67473e.js [HTTP/1.1 404 Not Found 1594ms] GET http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/595ecd69495765507396.js [HTTP/1.1 404 Not Found 1265ms] GET http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/78ed504e6dbe893d56d8.js [HTTP/1.1 404 Not Found 2561ms] JQMIGRATE: Migrate is installed, version 3.3.2 jquery-migrate-3.3.2.min_23.1200000.js:2:709 GET http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/77c7724cb7b76d9c6f1f.js [HTTP/1.1 404 Not Found 2511ms] Loading failed for the <script> with source “http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/77c7724cb7b76d9c6f1f.js”. run.pl:783:97 GET http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/b50d36cd3cebca67473e.js [HTTP/1.1 404 Not Found 1359ms] Loading failed for the <script> with source “http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/b50d36cd3cebca67473e.js”. run.pl:783:203 The resource at “http://127.0.0.1:8081/api/v1/contrib/paypal/static/_nuxt/78ed504e6dbe893d56d8.js” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly.
Created attachment 160147 [details] [review] Bug 34082: Cut some redundancy in OPAC JavaScript string translations This patch consolidates some JS code so that we're not defining a string ine one place and using it once elsewhere. With JS-friendly translations tools we don't need this workaround. To test, apply the patch and go to Administration -> Circulation and fine rules. - Configure an item type rule with the "OPAC item level holds" setting set to "Force." - Log in to the OPAC and locate a record with that item type and multiple items. An example in the sample data: /cgi-bin/koha/opac-detail.pl?biblionumber=12 - Place a hold on the item. - The holds screen should show a table of items. - Open your browser's developer tools. - In the Console tab, paste in this code and hit ENTER: $(".checkitem").prop("checked", false); - All radio buttons in the table of items should be cleared. - Click the "Confirm hold" button. You should get an alert: "Expecting a specific item selection." - Log in to the OPAC and click the "Search history" tab from the user summary page. - Check one or more checkboxes next to search history items and click the "Remove selected searches." - You should get an alert: "Are you sure you want to delete selected search history entries?" - Log in to the OPAC, create a new list if necessary, and add some titles to the list. - Test that confirmation messages show correctly: - Deleting a single title by clicking the "Remove from this list" link. - Deleting multiple titles by checking boxes and clicking "Remove from list." - Deleting a list. - In Administration -> System preferences, enable TagsEnabled if necessary. - Log in to the OPAC and tag one or more items. - From the Tag cloud page, check one or more boxes for your tags, and click the "Delete selected tags" button at the bottom of the page. - The confirmation message should display correctly. - To test the change to opac-account.tt you have to install a payment plugin, e.g. https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal, and attempt to submit a payment which is below the minimum payment threshold set in the plugin's configuration.
(In reply to David Nind from comment #3) > 2. Payment plugin: in the current master, the PayPal plugin doesn't work It works for me with the latest version (v2.5.0). I think you need to restart_all after uploading the plugin.
(In reply to Owen Leonard from comment #5) > (In reply to David Nind from comment #3) > > 2. Payment plugin: in the current master, the PayPal plugin doesn't work > > It works for me with the latest version (v2.5.0). I think you need to > restart_all after uploading the plugin. That was what I needed to do. Thanks!
Created attachment 160170 [details] [review] Bug 34082: Cut some redundancy in OPAC JavaScript string translations This patch consolidates some JS code so that we're not defining a string ine one place and using it once elsewhere. With JS-friendly translations tools we don't need this workaround. To test, apply the patch and go to Administration -> Circulation and fine rules. - Configure an item type rule with the "OPAC item level holds" setting set to "Force." - Log in to the OPAC and locate a record with that item type and multiple items. An example in the sample data: /cgi-bin/koha/opac-detail.pl?biblionumber=12 - Place a hold on the item. - The holds screen should show a table of items. - Open your browser's developer tools. - In the Console tab, paste in this code and hit ENTER: $(".checkitem").prop("checked", false); - All radio buttons in the table of items should be cleared. - Click the "Confirm hold" button. You should get an alert: "Expecting a specific item selection." - Log in to the OPAC and click the "Search history" tab from the user summary page. - Check one or more checkboxes next to search history items and click the "Remove selected searches." - You should get an alert: "Are you sure you want to delete selected search history entries?" - Log in to the OPAC, create a new list if necessary, and add some titles to the list. - Test that confirmation messages show correctly: - Deleting a single title by clicking the "Remove from this list" link. - Deleting multiple titles by checking boxes and clicking "Remove from list." - Deleting a list. - In Administration -> System preferences, enable TagsEnabled if necessary. - Log in to the OPAC and tag one or more items. - From the Tag cloud page, check one or more boxes for your tags, and click the "Delete selected tags" button at the bottom of the page. - The confirmation message should display correctly. - To test the change to opac-account.tt you have to install a payment plugin, e.g. https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal, and attempt to submit a payment which is below the minimum payment threshold set in the plugin's configuration. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 164842 [details] [review] Bug 34082: Cut some redundancy in OPAC JavaScript string translations This patch consolidates some JS code so that we're not defining a string ine one place and using it once elsewhere. With JS-friendly translations tools we don't need this workaround. To test, apply the patch and go to Administration -> Circulation and fine rules. - Configure an item type rule with the "OPAC item level holds" setting set to "Force." - Log in to the OPAC and locate a record with that item type and multiple items. An example in the sample data: /cgi-bin/koha/opac-detail.pl?biblionumber=12 - Place a hold on the item. - The holds screen should show a table of items. - Open your browser's developer tools. - In the Console tab, paste in this code and hit ENTER: $(".checkitem").prop("checked", false); - All radio buttons in the table of items should be cleared. - Click the "Confirm hold" button. You should get an alert: "Expecting a specific item selection." - Log in to the OPAC and click the "Search history" tab from the user summary page. - Check one or more checkboxes next to search history items and click the "Remove selected searches." - You should get an alert: "Are you sure you want to delete selected search history entries?" - Log in to the OPAC, create a new list if necessary, and add some titles to the list. - Test that confirmation messages show correctly: - Deleting a single title by clicking the "Remove from this list" link. - Deleting multiple titles by checking boxes and clicking "Remove from list." - Deleting a list. - In Administration -> System preferences, enable TagsEnabled if necessary. - Log in to the OPAC and tag one or more items. - From the Tag cloud page, check one or more boxes for your tags, and click the "Delete selected tags" button at the bottom of the page. - The confirmation message should display correctly. - To test the change to opac-account.tt you have to install a payment plugin, e.g. https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal, and attempt to submit a payment which is below the minimum payment threshold set in the plugin's configuration. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed for 24.05! Well done everyone, thank you!
Not backported to 23.11.x
Architecture change, nothing to add/edit in the Koha manual.