Bug 34086 - On detail.tt if item.permanent_location is NULL no shelving location will show
Summary: On detail.tt if item.permanent_location is NULL no shelving location will show
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-21 19:19 UTC by Lucas Gass
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 34086: Show location on detail page when there is no permenant location (2.24 KB, patch)
2023-06-21 19:22 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34086: Show location on detail page when there is no permenant location (2.29 KB, patch)
2023-06-22 16:35 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 34086: Show location on detail page when there is no permenant location (2.34 KB, patch)
2023-07-09 13:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2023-06-21 19:19:54 UTC
To recreate:

1. Have some items without a permanent location. 
2. Go to the staff detail page. 
3. In the 'Home library' column notice the span .shelvingloc is empty. 
4. Add a permanent location, now the shelvingloc is populated
Comment 1 Lucas Gass 2023-06-21 19:22:25 UTC
Created attachment 152538 [details] [review]
Bug 34086: Show location on detail page when there is no permenant location

To test:
1. Have some items without a permanent location.
2. Go to the staff detail page.
3. In the 'Home library' column notice the span .shelvingloc is empty.
4. Add a permanent location, now the shelvingloc is populated
5. Apply patch
6. The location should now show even when there is no permenant location.
Comment 2 Lucas Gass 2023-06-22 16:25:10 UTC
I am adding/removing the permanent location like so:

-sudo koha-shell kohadev
-update items set permanent_location = NULL;
update items set permanent_location = 'GEN';
Comment 3 Sam Lau 2023-06-22 16:35:35 UTC
Created attachment 152574 [details] [review]
Bug 34086: Show location on detail page when there is no permenant location

To test:
1. Have some items without a permanent location.
2. Go to the staff detail page.
3. In the 'Home library' column notice the span .shelvingloc is empty.
4. Add a permanent location, now the shelvingloc is populated
5. Apply patch
6. The location should now show even when there is no permenant location.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 4 Katrin Fischer 2023-07-09 13:44:13 UTC
I went through this the hard way adding a mapping for 952C on items.permanent_location and something seems to have got stuck in cache... but in the end all is well.
Comment 5 Katrin Fischer 2023-07-09 13:44:52 UTC
Created attachment 153215 [details] [review]
Bug 34086: Show location on detail page when there is no permenant location

To test:
1. Have some items without a permanent location.
2. Go to the staff detail page.
3. In the 'Home library' column notice the span .shelvingloc is empty.
4. Add a permanent location, now the shelvingloc is populated
5. Apply patch
6. The location should now show even when there is no permenant location.

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 6 Tomás Cohen Arazi 2023-07-10 18:43:13 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 7 Martin Renvoize 2023-07-18 09:33:35 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 8 Matt Blenkinsop 2023-07-18 14:07:14 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x